Archive 1 Archive 3 Archive 4 Archive 5

Beta: RfD error

When closing Wikipedia:Redirects for discussion/Log/2021 January 2#Akira (2009 film), I got the below error and had to add the talk page template manually.

TypeError: date.getUTCDate is not a function error: could not edit page Talk:Akira (2009 film)

fwiw, this followed a pop-up indicating that adding the Old RfD template would overwrite a redirect, though apparently Talk:Akira (2009 film) was not a redirect? It also threw an error rather than passing me the template code to add myself.

Not sure if related, but XFDC also didn't redirect to the section I specified in the form Akira (planned film)#Film rights and conception. Instead it just dropped the section and redirected to the article itself. czar 21:37, 2 January 2021 (UTC)

@Czar:   Fixed both of these issues are now. They weren't actually related, just both happened to affect RfD closes. Regarding It also threw an error rather than passing me the template code to add myself – that's because the error occurred while trying to create the wikitext (template code) for the talk page. - Evad37 [talk] 09:15, 20 January 2021 (UTC)

{{resolved}}

Beta: Unlinker struggles with anchor tag in section heading

{{resolved}}

Unlinking after deleting an article and got a prompt to process a bulleted link in the section "List: LA}}LA Giltinis", referring to List of 2020–21 Major League Rugby transfers § LA Giltinis but struggling with the section heading, which contains an anchor tag: =={{anchor|LA}}LA Giltinis== czar 21:50, 25 December 2020 (UTC)

  Fixed - Evad37 [talk] 15:55, 21 January 2021 (UTC)

Beta: Minimize jiggle

{{resolved}}

Both when loading the closer on the daily AfD page and after the AfD closes, I'm losing my place often with the beta when I generally want to refer to the discussion I was reading. There appears to be some page resituating when the closer is first loaded. And when the AfD is closed, v3 had more visual indication of the closed action, like it was easier to tell which one I just closed and where, if I scrolled through the page and looked at a glance. If there was some way to change the background of the section or otherwise indicate which discussions have been addressed, would help contextualize the change. czar 21:50, 25 December 2020 (UTC)

@Czar: The "jiggle" effect should now be prevented, most of the time, when dialogs open and close. - Evad37 [talk] 03:10, 22 January 2021 (UTC)
Closed/relisted discussions are now styled: the heading will be struck-through, and the discussion text will have 50% opacity. - Evad37 [talk] 04:52, 23 January 2021 (UTC)

Beta: Soft delete rationale

{{resolved}}

It would be great if the beta XFDcloser defaulted to using Wikipedia:XFDcloser/Soft deletion rationale when closing as 'soft delete' Eddie891 Talk Work 17:55, 16 January 2021 (UTC)

Speaking of soft delete, could we please get soft deletion enabled natively for non admins at TfD (section above)? I did write the code patch somewhere above. I’m a bit lazy to select delete and type it in :P ProcrastinatingReader (talk) 18:17, 16 January 2021 (UTC)
@Eddie891:   Fixed - Evad37 [talk] 15:56, 21 January 2021 (UTC)

Beta: Minor things

{{resolved}}

  1. Typo "Take care to avoid innapropriate non-administrator closes" (should be "inappropriate"). Though, I find the whole thing a bit distracting personally. Not sure if it's helpful. Probably more of a problem at AfD than at other deletion venues. At the very least, not sure that it needs to be a dropdown, as the hidden message is just as long as the collapse header.
  2. When clicking "preferences" the top menu still says "Cancel" on the top left, but clicking the button takes you back. It should probably say "Back".
  3. Go to a TfD, click to close, choose "no consensus" or "keep" and then click "Next" to reach the "Result options [holding cell etc]" menu. There's very little margin on the bottom of the oo-ui-fieldLayout-body, looks slightly strange.

ProcrastinatingReader (talk) 13:23, 23 January 2021 (UTC)

Fixed the typo/word choice for #1/#2. With the other stuff, the NAC warning is supposed to be at least somewhat distracting, so that users actually notice it. Though perhaps it can be something that users are able to dismiss, rather than showing up every time. And getting the height of OOUI windows to be "just right" is actually surprisingly difficult; I'll have to take another look (I think I might need to change some existing margins to paddings.) - Evad37 [talk] 17:44, 23 January 2021 (UTC)
@ProcrastinatingReader: The sizing of dialogs (#3) should be better now - Evad37 [talk] 11:54, 24 January 2021 (UTC)

Weird Notice

Received this in my watchlist:

Mai Minokoshi‎ diffhist -4‎ Spartaz talk contribs Removing link(s): Wikipedia:Articles for deletion/Cinema Today closed as delete (XFDcloser) rollback

Doesn't make sense, as one article has nothing to do with the other. Regards, GenQuest "Talk to Me" 07:42, 7 June 2020 (UTC)

Striking. They're both AfDs. Now I get it. Thanks. — Preceding unsigned comment added by GenQuest (talkcontribs) 08:11, 7 June 2020 (UTC)

{{User:ClueBot III/ArchiveNow}}

Spam

I keep getting spammed by this entity with a pop-up ad that says "Hey its now a gadget, here's how to enable that". Well I did that, and the ad keeps popping up anyway. What's more, there's not even an X to close the pop-up window, and I haven't figured out a way to do that -- I have to leave the page, which impacts my productivity. Is there any way to make this stop? Herostratus (talk) 14:35, 21 June 2020 (UTC)

Herostratus, you also need to remove (or comment out) the call to User:Mr.Z-man/closeAFD2.js in your vector.js, since it's a redirect to the old script. Primefac (talk) 14:44, 21 June 2020 (UTC)
Alright. But perhaps the pop-up could say that. Herostratus (talk) 14:46, 21 June 2020 (UTC)

{{User:ClueBot III/ArchiveNow}}

Beta: Auto-changed the assessed class when closing as redirect

When closing as 'redirect', it would be cool if the tool auto-changed the assessed class to 'redirect'. Just a thought. Eddie891 Talk Work 23:05, 17 November 2020 (UTC)

{{User:ClueBot III/ArchiveNow}} Archiving as this is already listed in the "Possible future features" box at the top of the page. - Evad37 [talk] 03:08, 26 January 2021 (UTC)

Beta: Multiple instances

{{resolved}}

In the past, I've been able to close multiple AfDs at once, which is especially useful when one is taking a while to unlink. Doesn't look like a second instance loads in v4. czar 21:50, 25 December 2020 (UTC)

@Czar:   Done, you can now open multiple instances. This wasn't actually as hard as I though it might be   - Evad37 [talk] 04:53, 23 January 2021 (UTC)

Watchlist

{{resolved}}

When closing an AfD, the discussion, the article, and any articles edited to remove backlinks are automatically added to my watchlist because I automatically watchlist articles that I edit. This adds large numbers of articles in which I am not interested at all to my watchlist and I have to spend a lot of time to weed them out. Would it be possible to have an option (like Twinkle does) where users can specify whether or not they want edited articles to be added to their watchlists (regardless of which options they have specified for their watchlists)? Thanks. --Randykitty (talk) 16:49, 16 June 2019 (UTC)

Adding stuff to watchlist?

This is something I've seen often. Sometimes, when I close the AfDs as keep or merge, the script adds the articles to my watchlist automatically. This is probably a bug? --Tone 08:59, 26 November 2019 (UTC)

Any comments on this one? I noticed it is happening again. --Tone 18:13, 15 December 2019 (UTC)
As Randykitty mentions above, if you have "Add pages and files I edit to my watchlist" enabled in Special:Preferences, then any pages edited using XFDcloser will be added to your watchlist. To allow users to control what XFDcloser does, I really need to implement preferences for XFDcloser. Which is something I'm looking at doing, along with modernising/improving the UI, like I recently did for WP:RATER. - Evad37 [talk] 01:45, 16 December 2019 (UTC)
Ok, thanks! --Tone 13:23, 16 December 2019 (UTC)

Rename option for CfD

{{resolved}}

Hi, I was wondering if it's possible to add a rename option to the possible default results. This would be equivilent to using the custom option with the text "Rename". ‑‑Trialpears (talk) 23:04, 4 November 2019 (UTC)

  Acknowledged. Will add this in the next major version, when I redo the interface. - Evad37 [talk] 02:54, 19 December 2019 (UTC)

Log summary change request

{{resolved}}

I'd like:

G8: Talk page of a deleted page. (XFDcloser)
Delete redirect: Wikipedia:Articles for deletion/Fat (song) closed as delete (XFDcloser)

to both be changed either to

G8: Wikipedia:Articles for deletion/Fat (song) closed as delete (XFDcloser)

or

G8: Wikipedia:Articles for deletion/Fat (song) (XFDcloser)

Reason: more explanatory and word-flowy. Also we don't put a period after deleting a talk page when the associated page is deleted per PROD/CSD, and we should explain what reason to delete redirects AFD or not, not bring up what is already happening in our eyes. (Disclaimer: Fat (song) is a placeholder and that AFD is actually a run-of-the-mill April Fools joke. ミラP 04:13, 26 December 2019 (UTC)

@Miraclepine: This will be fixed in the next major version of XFDcloser. Some indication that a page was a redirect should still be left in the log, as once a redirect has been deleted and is a redlink there is no other way to know it was a redirect (apart from admins viewing deleted revisions). Perhaps
     G8 (redirect): Wikipedia:Articles for deletion/Fat (song) closed as delete (XFDcloser)
unless anyone has a better idea. - Evad37 [talk] 07:48, 13 April 2020 (UTC)

Automated actions at CfD

{{resolved}}

I know this has been discussed before somewhere, but I just couldn't find the discussion. Doing the usually automated actions of removing nom-templates and adding {{old cfd}} takes quite a lot of time and really should be automated here as well. It looks like a lot of ground work is done for these features with old cfd formatting and nom-template regexs appearing in the source code so is there and I don't really see anything that different about CfD compared to other venues in this area. What would happen if the code handling CfD in basic mode was removed? --Trialpears (talk) 21:44, 11 July 2020 (UTC)

I just want to say that I'm so happy that this is on the agenda for 4.0! It will make such a huge difference and will likely have a significant impact on the CfD backlog. --Trialpears (talk) 23:05, 20 January 2021 (UTC)

A little bug: "{{subst:^|<strong>}}" showing up inside references

{{resolved}}

I don't quite see what that void subst-ing is being used for in this script, but since subst-ing doesn't work inside references it results in this string appearing in articles, see here and here. Not a very common problem, I've just fixed about 20 instances of this, but maybe this can be avoided. – Thjarkur (talk) 16:44, 27 July 2020 (UTC)

  Acknowledged. That's the result of a hack I used during the backlink removal process/dialogs. It's supposed to disappear when saved, except I forgot that substitution doesn't work within refs... I'll have to make the script do a bit of cleanup before saving. - Evad37 [talk] 01:18, 31 August 2020 (UTC)
Fixed in Beta version - Evad37 [talk] 15:55, 21 January 2021 (UTC)

Cannot run this any more

{{resolved}} In my More tab XFDC Prefs appears (and I can access those), but I can no longer see/use the tool. I have not knowingly changed anything. Thoughts, please? Ping me on answers, or I may miss it. FiddleTimtrent FaddleTalk to me 11:37, 20 June 2021 (UTC)

It's possible its use may now be restricted to admins, of which I am not one FiddleTimtrent FaddleTalk to me 11:58, 20 June 2021 (UTC)
@Evad37, are you able to offer advice, please? FiddleTimtrent FaddleTalk to me 11:03, 23 June 2021 (UTC)
Whatever it is, I still cannot use the tool. Now it's not urgent, because I close very few discussions, but I'd love to know what the issue might be, please? FiddleTimtrent FaddleTalk to me 09:31, 30 June 2021 (UTC)
@Primefac, you seem knowledgable here. Any thoughts, please? FiddleTimtrent FaddleTalk to me 21:32, 20 July 2021 (UTC)
Genuinely can't think of a reason other than potentially something browser-related, as I'm seeing a fair number of NAC/XFDC closes, and no one else has commented. Have you tried a different browser? Primefac (talk) 22:48, 20 July 2021 (UTC)
@Timtrent A couple of things to try: 1) Open up the javascript console on your browser and see if there's anything useful logged. 2) Open an incognito window on Chrome (Private window on Firefox or Safari), login to your wiki account, and see if you still get the problem there. -- RoySmith (talk) 23:04, 20 July 2021 (UTC)
I wonder if it's also a mismatch between the Gadget and user scripts - is XFDC still listed in your user script location of choice? Primefac (talk) 23:05, 20 July 2021 (UTC)
@RoySmith@RoySmith I've tried Safari, my usual browser, and Opera with and without a private window in each. IN all four windows the More tab has only XFDC Prefs in the drop down.
My user script location has very little in it:
Extended content
/* User:Zhaofeng Li/Reflinks.js */ importScript( 'User:Zhaofeng Li/Reflinks.js' );// Backlink: User:Zhaofeng Li/Reflinks.js
/*importScript( 'User:Enterprisey/reply-link.js' ); // Backlink: User:Enterprisey/reply-link.js*/
importScript( 'User:Evad37/MoveToDraft.js' ); // Backlink: User:Evad37/MoveToDraft importScript( 'User:Enterprisey/cv-revdel.js' ); // Backlink: User:Enterprisey/cv-revdel.js importScript('User:Awesome Aasim/xfdvote.js'); // Backlink: User:Awesome Aasim/xfdvote.js importScript('user:Qwertyytrewqqwerty/DisamAssist.js'); // Backlink: user:Qwertyytrewqqwerty/DisamAssist.js
MY Javascript console says
[Warning] Use of "addPortletLink" is deprecated. Use mw.util.addPortletLink instead (Draft:China_COVID-19_cover-up, line 682)
[Warning] You installed the userscript User:Smith609/toolbox.js (index.php, line 2)
It is no longer working and you should uninstall it.
[Info] (index.php, line 63)
== CVD bug report for Wikipedia:Miscellany_for_deletion/Draft:China_COVID-19_cover-up by Timtrent ==
Timtrent (talk · contribs · central auth · count · email) (usergroups) loaded Wikipedia:Miscellany for deletion/Draft:China COVID-19 cover-up at 06:19:48, July 21, 2021 (UTC).
Timtrent is only opening all links using copyvios.The script found the following 8 link(s) and filtered out 0 duplicate(s) and 4 invalid link(s). This left the 4 URL(s) listed below.
Links and URLs returned by script
Links
URLs
The whole thing is way past my technical know how FiddleTimtrent FaddleTalk to me 06:22, 21 July 2021 (UTC)
@Timtrent I don't see anything obvious in the console output. The fact that you get the same behavior in different browsers and/or private mode rules out things like browser-side caching or cookies. I just enabled XFDCloser on a non-admin account of mine (RoySmith-testing), and it worked fine there, so that rules out "you need to be an admin".
The next thing I tried was copying User:Timtrent/common.js to User:RoySmith-testing/common.js. I was fully expecting things to fail at this point, but to my astonishment, it still worked fine. So, I'm stumped. There's obviously something about the state of your account that's not stored in browser-side persistent state (i.e. cache and cookies), nor in common.js. Is it possible you've got some additional javascript (vector.js, etc) that might be loading? The only other thing I can think of is maybe you've got some other option set in your preferences (perhaps another gadget?) that's interacting badly with XFDCloser?
I don't know how far you want to go down the rathole, but the next thing I would suggest is you create another account (it'll need to be extended-confirmed to enable the gadget, but I'll be happy to anoint it for you) and step-by-step recreate your preferences to see when (if?) it stops working. Of course, put a note on the new account's user page so it doesn't get whacked as a sock. -- RoySmith (talk) 11:48, 21 July 2021 (UTC)
@RoySmith I'll give it a hard stare again in a few minutes. What if I untick preferences and see if it ever starts working? I'll look for other sub page, too FiddleTimtrent FaddleTalk to me 12:34, 21 July 2021 (UTC)
@RoySmith I have the following .js pages
The significance of the various .js files escapes me and I am only on distant terms with their contents, like meeting an estranged aunt
I can list my preferences if this becomes useful FiddleTimtrent FaddleTalk to me 12:48, 21 July 2021 (UTC)
I copied all those over to my testing account, and still can't get it to fail. So, at this point, I have no clue what's going on. Wish I could be more useful.
One general suggestion is to get rid of your monobook.js and vector.js. Those are skin-specific scripts. The idea is that if you're using monobook, you get common.js + monobook.js, and if you're using vector, you get common.js + vector.js. The vast majority of people only use a single skin, so just putting whatever you need into common.js and getting rid of the others simplifies things. That won't fix whatever's going on here, but it'll be one less complication in an already over-complicated world.
I noticed you've already got User:Fiddle Faddle, so see if this works from that account. As for unticking preferences, that's not an unreasonable way to attack this, but it has the problem that unless you're very methodical about recording what you've changed, it'll be difficult to get things back to exactly the way they were before. -- RoySmith (talk) 14:38, 21 July 2021 (UTC)
I appreciate your help @RoySmith I'll work steadily through it. Screenshots are a way to go. I'll also see it if it works from @Fiddle Faddle. Does that account have the correct permissions? I try never to use it
The two .js files are ether already deleted or up for CSD FiddleTimtrent FaddleTalk to me 15:41, 21 July 2021 (UTC)
I've just granted Extended Confirmed to User:Fiddle Faddle -- RoySmith (talk) 15:51, 21 July 2021 (UTC)
@RoySmith: This is from my FF account. It only has commons.js. In prefs I asked it to restore all default settings. I went to look at Wikipedia:Miscellany for deletion/Draft:China COVID-19 cover-up which I have been using throughout to see if it will work! (I know I am not entitled to close it because I have participated imn ity in my real life account. I am not there to take any action), and the FF More tab also only shows XFDC Prefs. I'm happy privately by email to share the FF login credentials with you for diagnostic purposes if that is allowed under our rules and if you are happy to play further. Fiddle Faddle (talk) 16:22, 21 July 2021 (UTC)
obvs, I did tick the XFD Closer tool!!! FiddleTimtrent FaddleTalk to me 16:29, 21 July 2021 (UTC)
No, please don't send me your credentials. That's never a good plan. I'm afraid I'm going to have to bail here. I'm totally out of ideas. -- RoySmith (talk) 17:22, 21 July 2021 (UTC)
@RoySmith I think I will just not close any more deletion discussions. I never closed many, but some were interesting
Isn't it bizarre? FiddleTimtrent FaddleTalk to me 19:39, 21 July 2021 (UTC)

Xfd closer malfunction

{{resolved}} I wish to withdraw my nomination from an AfD. I am trying to use my XFD closer. But the only button I have for this is "xfdc preferences." When I click on that I don't get the box that asks me to choose what kind of close. Instead I see something about enabling Beta version, add edited pages to my watchlist, collapse task warnings if at least:, and collapse task errors if at least. Is the xfd closer malfunctioning or is my particular closer malfunctioning? I am unable to close this AfD using the XfD closer. ---Steve Quinn (talk) 21:01, 10 August 2021 (UTC)

If someone wants to look at the page, here is the AfD [1]. I am not interested in having the AfD closed. I am interested in having my XFD closer work. Thanks. ---Steve Quinn (talk) 21:10, 10 August 2021 (UTC)

Possible duplicate of the issues described in #Cannot run this any more above? Primefac (talk) 21:40, 10 August 2021 (UTC)
@Primefac: Thanks for responding so quickly. I resolved the problem with my un-technical non-expertise. I was reading the above thread entitled "Cannot run this any more." Then I came up with the idea to uncheck the XFD closer in my Gadgets, save it, and then close my browser. Then I reopened my browser, re-checked XFD closer in Gadgets, and saved that. I closed the browser again, came back, and found it working. I am writing all this because maybe it will help someone else in the future. ---Steve Quinn (talk) 22:26, 10 August 2021 (UTC)
I can also reccomend trying a different browser as suggested in the above thread that you and I mentioned, "#Cannot run this any more." ---Steve Quinn (talk) 22:29, 10 August 2021 (UTC)
Hopefully this is a helpful ping. Primefac (talk) 22:41, 10 August 2021 (UTC)
@Primefac A little like when the days of old TV repair man came to repair your set and it decided to work perfectly I have revisited the issue. Thank you for the ping. I decided to check an XfD and the little close things are now present where they were previously absent. I changed nothing. Perhaps some underlying issue changed on my Mac. Thank you for the ping. FiddleTimtrent FaddleTalk to me 08:32, 11 August 2021 (UTC)

Bug report: XfD closer broken

{{resolved}} I can't currently use the script because the text fields for the result and the rationale don't show up. Screenshot: https://imgur.com/a/i6Z1WOW. I'm using the current Chrome browser on Windows 10. Sandstein 11:18, 21 January 2022 (UTC)

Can confirm, does not work on Firefox either (checked both the AFD Sandstein is having issues with as well as a few WP:TFD listings). Primefac (talk) 11:33, 21 January 2022 (UTC)
Just on the off chance that Evad37 isn't paying as much attention as necessary due to the ongoing RFC.... ping! Problems abound. Primefac (talk) 20:37, 21 January 2022 (UTC)
  • Can confirm this gadget is broken on WP:RFD; the "Rationale" and "Preview" options do not work. Tried on Safari and Chrome. Steel1943 (talk) 18:38, 21 January 2022 (UTC)
  • As a workaround, I am using it to close, then adding any additional text as a follow-up edit. This seems to work fine and avoids the need to apply the close templates manually. --RL0919 (talk) 20:32, 21 January 2022 (UTC)
    Same. The first time I thought I misclicked, which I have been known to do. But it is persisting. AfD on Mac, no os updates since it last worked. Broken in both Chrome and Firefox. Star Mississippi 23:23, 21 January 2022 (UTC) ETA example if helpful. Star Mississippi 03:06, 22 January 2022 (UTC)
    I've noticed this too. It doesn't seem to be limited to XfDcloser: the text fields for adding captions to images in VisualEditor have vanished as well. The problem's onset did seem to coincide with a certain day of the week... Extraordinary Writ (talk) 00:47, 22 January 2022 (UTC)

Investigating now. My suspicion is a breaking change to mw:OOUI. (Please continue to ping me and/or leave talk page messages when reporting urgent issues, or if I'm taking a long time to reply. My watchlist is too big to be useful given that I'm less active then I used to be.) - Evad37 [talk] 01:13, 22 January 2022 (UTC)

  Fixed - Evad37 [talk] 03:09, 22 January 2022 (UTC)
Many thanks. Sounds like a typical THURSDAY snafu. Primefac (talk) 15:12, 22 January 2022 (UTC)

Query

{{resolved}} I'm seeing an admin use XFDcloser to remove links from deleted articles that are not deleted through XFD discussions. How is that possible? I'd like to find a tool to use to do that but reading over the tool page, I don't see how XFDcloser can be used to remove links from articles deleted through PROD or CSD. I'd appreciate any information anyone familiar with the tool can provide. Many thanks. Liz Read! Talk! 00:34, 2 May 2022 (UTC)

Liz, Twinkle can remove backlinks. (I don't close enough AFDs to say if it's possible with XFDCloser. It is not possible when closing a TFD to remove backlinks.) Izno (talk) 01:39, 27 June 2022 (UTC)
Though, if you look a couple sections up, there is a strong implication that XFDCloser can remove backlinks. Izno (talk) 01:39, 27 June 2022 (UTC)
@Liz,   User:Evad37/Xunlink is what you want—it works on any article. It's built on the automatic unlinking that happens after XFDcloser's AfD closures. And it has smarter detection rules than Twinkle's. czar 01:47, 27 June 2022 (UTC)
Belated thank yous to Izno and Czar. I appreciate the suggestions! Liz Read! Talk! 22:56, 11 August 2022 (UTC)

Bug: XFDcloser messes up talk page redirects

{{resolved}} See this. It should have an exception for this. Piotr Konieczny aka Prokonsul Piotrus| reply here 02:59, 18 August 2022 (UTC)

That's not a bug. XFDC asks when there is a talk page redirect whether or not to overwrite the redirect with the old RfD template. -- Tavix (talk) 03:04, 18 August 2022 (UTC)

Problem with XFDcloser and bundled nominations at AFD

{{resolved}} Hello, all,

I'm having no luck with XFDcloser closing AFD nominations where there are a lot of articles bundled together. These have been nominations proposed by different editors so I know it isn't just one person not understanding how to do this. XFDcloser deleted the primary, first article mentioned in the nomination and ignores all of the articles listed (sometimes they are hatted, sometimes they are not). This requires a manual deletion of sometimes dozens of separate articles which can be a little time-consuming. Or, you can make a huge blunder, like I did last night, and try to batch delete them using Twinkle and end up with a huge mess to clean up. That's a mistake you only make once.

What do you think might be the problem here? Is it XFDcloser or is it the way that the bundled nomination is formatted that XFDcloser can't "see" all of the other articles that are proposed for deletion? I've discussed this with the nominators and maybe there just has to be a better explanation in the instructions for bundled nominations. Thanks for any ideas you can offer. Liz Read! Talk! 21:27, 21 August 2022 (UTC)

Can you link some recent examples? The most common issue I've found is that bundled noms are not detected as bundled unless the secondary articles use the {{la}} template. I usually make this correction and then refresh the nomination to make sure XFDC counts all affected pages in its counter before continuing. czar 23:15, 21 August 2022 (UTC)
I am going to second Czar on this one - XFDC will only flag the pages that are actually listed properly (this happens on TFD nominations all the time). The "whoops" mentioned above occurred due to Wikipedia:Articles for deletion/Mazraeh-ye Tahqiqati Tutun; each of the hatted wikilinks would need to be listed in {{la}} in order for XFDC to pick them up. Sometimes it's easier to follow Czar's method and convert them, I will often copy the entire list to a subpage so that I can use Twinkle's d-batch functionality (as mentioned on your talk page in the related thread). Primefac (talk) 12:48, 22 August 2022 (UTC)

Daily deletion log pages not loading correctly

{{resolved}} Hello, XFDCloser

The daily deletion log pages are not loading correctly. But it's not a good sign though that apparently the maintainer, Evad37, is inactive. There should really be a backup contact person as when the systems fail, they seem to fail spectacularly and affect the work of a lot of editors. Help! Liz Read! Talk! 01:29, 1 January 2023 (UTC)

not loading correctly - what do you mean? Primefac (talk) 13:08, 1 January 2023 (UTC)
Hello, Primefac,
I was just coming to remove this query from the page. I tried a lot of different solutions that were suggested at VPT (adding/removing scripts from .js page, working with Preferences, etc.) and it turns out that "Hide/Show closed discussions" button disappeard from the daily deletion log pages so all of the closed discussions were hidden and there was no way to get them to show back up because there was no longer any button to toggle. I rebooted, cleared out my cache and cookies and, for some reason, the button came back into view. But because my problem appeared at exactly the time it changed from 2022 UTC to 2023 UTC, I thought it might be a system problem but it turns out it was just a problem with my browser. Liz Read! Talk! 02:13, 2 January 2023 (UTC)
Good to know! Primefac (talk) 08:38, 2 January 2023 (UTC)

Add a delete button

{{resolved}} Add a delete button when closing a discussion, instead of having to add manually via the custom button. Preferably put it after the third tab/button, "soft redirect". Qwerty284651 (talk) 02:58, 2 February 2023 (UTC)

Uh... XFDC does have a delete option? Primefac (talk) 20:57, 2 February 2023 (UTC)
It doesn't render for non-admins. But yeah, Qwerty appears to not know that deletion is an admin-only action. signed, Rosguill talk 21:47, 2 February 2023 (UTC)
I've closed loads of CfDs as delete. But outside of CfD, it's probably unhelpful. — Qwerfjkltalk 21:51, 2 February 2023 (UTC)
Thanks for the input you, guys. Qwerty284651 (talk) 22:04, 2 February 2023 (UTC)

Missing "soft delete" button?

{{resolved}} I have the ability to close as a "regular" delete, but no option to soft-delete. Running on Chrome. Joyous! | Talk 19:59, 12 February 2023 (UTC)

Soft deletion is (should be) an additional option checked after selecting deletion as the option. Do you not see this option at all? What flavour of XFD are you attempting to use it on? Primefac (talk) 12:24, 13 February 2023 (UTC)
Well. Heck. It's sitting right there. I was looking for it among the options before selecting "delete." I've closed many a discussion with a delete, and somehow managed not to see those checkboxes. Thanks for your help! (and pardon me while I slink away to hide my red face) Joyous! | Talk 17:13, 13 February 2023 (UTC)
Super-easy to miss the non-obvious :-) Just glad it was an easy fix and not something broken! Primefac (talk) 20:09, 13 February 2023 (UTC)

Loading problem

I've opened multiple AfD pages in the last 15 minutes, using two different browsers on different devices, but XFDCloser doesn't appear to be loading on any of them. No close/relist links, and or the option to show/not show closed discussions. I've not had this problem previously. RL0919 (talk) 06:59, 22 January 2024 (UTC)

RL0919, I had this problem on my tablet, and hacked together this script, which just adds a link to load XFDCloser;
mw.util.addPortletLink ( 'p-tb', "javascript:importScript('MediaWiki:Gadget-XFDcloser-core.js')", 'Load XFDCloser', 'pt-loadxfdc', 'Manually loads XFDCloser');
— Qwerfjkltalk 16:26, 22 January 2024 (UTC)
Unable to reproduce on Vector 2010. Are you two getting any WP:CONSOLEERRORs? Which skin is being used? –Novem Linguae (talk) 18:44, 22 January 2024 (UTC)
Novem Linguae, I don't get the bug on my computer, but I believe the error was some missing dependency (unable to inherit Origin or something). I'll see if I can reproduce the error and give the actual error message. — Qwerfjkltalk 19:02, 23 January 2024 (UTC)
@Novem Linguae: I am using Vector 2022.The most relevant console error is probably this one: "Parse error: Unexpected: ( on ext.gadget.XFDcloser-core-script-0.js:24 line 21". Qwerfjkl's load button hack does work for me, even though the console error still appears. --RL0919 (talk) 17:04, 24 January 2024 (UTC)
A syntax error would normally break the whole file for everyone, so really weird that it's just happening to you. Also, MediaWiki:Gadget-XFDcloser-core.js is minified, which makes debugging harder. –Novem Linguae (talk) 18:24, 24 January 2024 (UTC)
I think it is happening to me as well. I'm using the Vector legacy (2010) skin. XFDcloser is not loading in any of the AfDs. ❯❯❯ Raydann(Talk) 15:52, 25 January 2024 (UTC)
Novem Linguae, I suspect it's a script conflict. @RL0919, @Raydann, what happens if you blank your .js pages? — Qwerfjkltalk 16:14, 25 January 2024 (UTC)
Problem still persists after blanking my common.js ❯❯❯ Raydann(Talk) 16:23, 25 January 2024 (UTC)
I previously tried blanking both common.js and vector.js, but this had no apparent impact on the problem. --RL0919 (talk) 17:25, 25 January 2024 (UTC)
I've been getting this issue on Vector 2010 too czar 03:59, 26 January 2024 (UTC)
But today it's working fine czar 22:59, 26 January 2024 (UTC)
I've been having this problem for the last twenty-four hours or so with Vector 2010. It works just fine with the other skins (even MonoBook!), interestingly. Extraordinary Writ (talk) 00:39, 28 January 2024 (UTC)
And now working again. Extraordinary Writ (talk) 23:30, 28 January 2024 (UTC)
Yes, for me it works in every skin except Vector legacy 2010. ❯❯❯ Raydann(Talk) 20:11, 29 January 2024 (UTC)
Novem Linguae, I'm getting the following error:
Uncaught Error: inheritClass: Origin is not a function (actually undefined)
    at OO inheritClass (oojs.js:85:9)
    at 164.../../globals (<anonymous>:21:126600)
    at o (<anonymous>:21:254)
    at <anonymous>:21:288
    at 170.../../globals (<anonymous>:21:145875)
    at o (<anonymous>:21:254)
    at <anonymous>:21:288
    at 225.../../globals (<anonymous>:21:469338)
    at o (<anonymous>:21:254)
    at <anonymous>:21:288
But I have a more serious error: Parse error: Unexpected: ( on line 21
which means I cannot run the normal version of XFDCloser at all. THe beta version still works. — Qwerfjkltalk 21:35, 27 January 2024 (UTC)
I'm getting a similar error, using Monobook on Chrome 121.0.6167.139 for Mac (arm64). Same on Edge 121.0.2277.98.
Parse error: Unexpected: ( on line 21
css @ ext.gadget.XFDcloser-core-beta-script-0.js:24
runScript @ startup.js:1275
(anonymous) @ startup.js:1353
flushCssBuffer @ startup.js:606
requestAnimationFrame (async)
addEmbeddedCSS @ startup.js:637
execute @ startup.js:1367
doPropagation @ startup.js:757
requestIdleCallback (async)
setAndPropagate @ startup.js:830
impl @ startup.js:2009
(anonymous) @ load.php?lang=en&modules=ext.gadget.XFDcloser-core-beta&skin=monobook&version=1t9io:1
-The WordsmithTalk to me 19:01, 6 February 2024 (UTC)
The Wordsmith, try switching to the beta script. — Qwerfjkltalk 19:08, 6 February 2024 (UTC)
I'm not seeing an option to switch to the beta script, where is it located? The WordsmithTalk to me 19:37, 6 February 2024 (UTC)
Update: I used the addPortletLink above, and was able to make it load. It turns out I was already on Beta, once I could load my Preferences. Converting back to the standard version, reloading and purging my cache got it to load consistently on that AFD and several others. I tried to reproduce the issue by re-enabling the beta version and reloading the page, and again it stopped loading on AFDs. Repeating the process of going back to standard version and reloading fixed it again. For me, it seems like the problem is with the beta version only. The WordsmithTalk to me 20:29, 6 February 2024 (UTC)
Strange, I have the opposite problem. — Qwerfjkltalk 21:27, 6 February 2024 (UTC)
I am also having this error on vector-2022 and @Qwerfjkl's hack isn't working. The script works perfectly fine without Q's hack on all of the other skins.
I am also getting the following error on vector-2022:
Parse error: Unexpected: ( on line 21 ext.gadget.XFDcloser-core-beta-script-0.js:24:1
<anonymous>ext.gadget.XFDcloser-core-beta-script-0.js:24
runScriptstartup.js:1275
cssHandlestartup.js:1353
flushCssBufferstartup.js:606
Pinging @Novem Linguae as well. voorts (talk/contributions) 19:59, 19 February 2024 (UTC)
Not sure how good you are with DevTools, but if that happens again, can you try going to the location of the error and copy/paste the code that is causing the parse error? This would either involve clicking on the line number in the stack trace, or going to the network tab and finding ext.gadget.XFDcloser-core-beta-script-0.js and taking a peek at its contents. Somewhere else on this page we theorized that a mediawiki error message was being sent instead of the program code for XFDCloser, causing this parse error. I think if we are able to read this mediawiki error message, we can do further debugging. –Novem Linguae (talk) 20:11, 19 February 2024 (UTC)
@Novem Linguae: Is this what you're looking for:
Extended content

(Large block of minified code, removed as not relevant)

voorts (talk/contributions) 20:18, 19 February 2024 (UTC)
@Novem Linguae: Upon further inspection, although my error message says line 21, it links to https://en.wikipedia.org/w/virtual-resource/ext.gadget.XFDcloser-core-beta-script-0.js:24, and when I click through, it goes to line 24 of the beta script (which I copied to the extended content above), For the non-beta script, here's line 21: /* jshint esversion: 5, esnext:false, laxbreak: true, undef: true, eqnull: true, maxerr: 3000 */ and here's line 24: (function(){ voorts (talk/contributions) 23:38, 19 February 2024 (UTC)
@Novem Linguae: any word on this? Thanks, voorts (talk/contributions) 22:35, 3 March 2024 (UTC)
This looks like it's not easily reproducible, making it a class of bug that will be really hard to fix. Based on the comments so far, I think SD0001's theory about Peast validation sometimes failing and then the error message getting cached is the most likely explanation given so far. Has anyone made a Phabricator ticket about this yet? Problems with Peast should get a Phabricator ticket. I guess tag the new Phab ticket with MediaWiki-ResourceLoader? Perhaps SD0001 would be willing to make the ticket?
Also voorts, can you state how often this is happening for you? –Novem Linguae (talk) 01:11, 4 March 2024 (UTC)
It's occurring consistently. The links haven't shown up at AfD, CfD, FfD, MfD, or TfD discussions for me for a while. voorts (talk/contributions) 01:54, 4 March 2024 (UTC)
phab:T359014. – SD0001 (talk) 06:22, 4 March 2024 (UTC)
It came back for me again too, I'm able to gather some more data. For me, it links to [2], and the text seems to be the normal gadget code (where everything is on line 21) but with a 3-line comment at the top containing the gadget name MediaWiki:Gadget-XFDcloser-core-beta.js. Clicking on the source mapping, it takes me to load.php?lang=en&modules=ext.gadget.XFDcloser-core-beta&skin=monobook&version=1t9io which contains this function:
mw.loader.impl(function() {
    return ["ext.gadget.XFDcloser-core-beta@1svn5", function($, jQuery, require, module) {
        mw.log.error("Parse error: Unexpected: ( on line 21");
    }
    , {
        "css": [".xfdc-status{font-size:small;margin-left:13px;font-weight:normal}.skin-timeless .xfdc-status{font-size:0.98rem}.skin-minerva .xfdc-status{font-size:0.98rem;display:block;margin:-1rem 0 1rem}.xfdc-action{font-weight:normal}.xfdc-action a{cursor:pointer}.xfdc-qc-cancel{cursor:pointer;border:1px solid #777;border-radius:10px;font-weight:bold;font-size:90%;color:#777;padding:0;margin:0 1px} .xfdc-old .xfdc-action{background-color:#c6ffc6}.xfdc-notOld .xfdc-action{background-color:#ffc6c6}.xfdc-unknownAge .xfdc-action{background-color:#ffffc6}.xfdc-notOld.xfdc-relisted .xfdc-action{background-color:#ffe9c6} .xfdc-actioned-heading{text-decoration:line-through double black;opacity:75%}.xfdc-actioned-discussion{opacity:50%} html body.ooui-draggbleWindow-open{position:unset;overflow:unset;margin-right:unset !important; }html body.ooui-draggbleWindow-open .oo-ui-windowManager-modal \u003E .oo-ui-dialog.oo-ui-window-active{position:static;padding:0} html body.ooui-draggbleWindow-open .oo-ui-dialog.oo-ui-window-active \u003E div{z-index:110;transition:all 0.25s ease-out 0s,transform 0s !important}  .oo-ui-textInputWidget.oo-ui-textInputWidget-labelPosition-before.padLeft2em .oo-ui-inputWidget-input{padding-left:2em !important}.oo-ui-textInputWidget.oo-ui-textInputWidget-labelPosition-before.padLeft4em .oo-ui-inputWidget-input{padding-left:4em !important} .xfdc-menuOptionWidget.oo-ui-decoratedOptionWidget{padding:7px 12px} .xfdc-taskItemWidget \u003E .oo-ui-fieldLayout-messages{clear:both} #XFDcloser-showhide{bottom:0;display:block;position:fixed;right:0;z-index:100;padding:5px;box-shadow:0 2px 4px rgba(0,0,0,0.5);background-color:#fef9e6;border:1px solid #aaa;border-radius:5px;font-size:85%}"]
    }];
});
// Saved in localStorage at 2024-02-12T22:09:25.448Z
//# sourceURL=https://en.wikipedia.org/w/load.php?lang=en&modules=ext.gadget.XFDcloser-core-beta&skin=monobook&version=1t9io
//# sourceMappingURL=/w/load.php?lang=en&modules=ext.gadget.XFDcloser-core-beta&skin=monobook&sourcemap=1&version=1t9io

Not sure how helpful this is, but I'll collect any additional data you need. The WordsmithTalk to me 20:46, 19 February 2024 (UTC)

This code is similar/identical to Nardog's code below, so I think we're on the right track, but I was hoping to get whatever file has the line 21 referred to in Parse error: Unexpected: ( on line 21. That might have an error message that could be further debugged. –Novem Linguae (talk) 23:29, 19 February 2024 (UTC)
I wasn't able to see anything with something strange on line 21, but I suspect it's the XFDCloser script that shows an issue on line 24 (just without that 3-line comment). I exported my console log; I won't paste it on this page for the sake of keeping this discussion readable but I uploaded it here. The WordsmithTalk to me 01:05, 20 February 2024 (UTC)

Buttons not showing up, "Parse error: Unexpected: ( on line 21" on Vector legacy

Anybody else not seeing "[Close] [quickClose] [Relist]" and getting "Parse error: Unexpected: ( on line 21" in console? Seems to be happening on every XfD page. I tried disabling all gadgets except XFDcloser and still got it. The console says it's coming from ext.gadget.XFDcloser-core-script-0.js:24:1 (not 21!), which is not helpful. Works on every other skin and, worse, in debug mode. Nardog (talk) 17:35, 8 February 2024 (UTC)

Nardog, see #Loading problem, one of the solutions there might help. — Qwerfjkltalk 18:02, 8 February 2024 (UTC)
Oh, sorry for not looking enough. This is such a head scratcher. I can't even figure out what's ultimately emitting the error, or line 21 of what, and we all seem to have different conditions for reproducing it. Nardog (talk) 23:49, 8 February 2024 (UTC)
I tried reproducing it today, exact same conditions but the gadget loaded fine on standard and beta. Very curious. But if I'm looking at MediaWiki:Gadget-XFDcloser-core.js right, its ALL on line 21. The WordsmithTalk to me 02:41, 9 February 2024 (UTC)
If #Request: turn off minifier is actioned, errors would probably give a more accurate line number. –Novem Linguae (talk) 05:48, 9 February 2024 (UTC)
Ah, the SourceMap source is 3 lines off because it inserts the name of the gadget at the top.
Whether you have enabled beta should not have to do with the culprit because currently the release and beta scripts are completely identical. If it makes a difference it must simply be that it somehow affects the race condition. (And the "Origin is not a function" error above is simply an effect of loading the script directly without the dependencies given in MediaWiki:Gadgets-definition.)
Turns out, the error message is generated by the server-side script validation (ironically the source map was a hindrance to discovering this). https://en.wikipedia.org/w/load.php?lang=en&modules=ext.gadget.XFDcloser-core&skin=vector&version=m2csj, which is where I got the error from, currently returns:
mw.loader.impl(function(){return["ext.gadget.XFDcloser-core@30cwo",function($,jQuery,require,module){mw.log.error("Parse error: Unexpected: ( on line 21");
},{"css":[".xfdc-status{font-size:small;margin-left:13px;font-weight:normal}.skin-timeless .xfdc-status{font-size:0.98rem}.skin-minerva .xfdc-status{font-size:0.98rem;display:block;margin:-1rem 0 1rem}.xfdc-action{font-weight:normal}.xfdc-action a{cursor:pointer}.xfdc-qc-cancel{cursor:pointer;border:1px solid #777;border-radius:10px;font-weight:bold;font-size:90%;color:#777;padding:0;margin:0 1px} .xfdc-old .xfdc-action{background-color:#c6ffc6}.xfdc-notOld .xfdc-action{background-color:#ffc6c6}.xfdc-unknownAge .xfdc-action{background-color:#ffffc6}.xfdc-notOld.xfdc-relisted .xfdc-action{background-color:#ffe9c6} .xfdc-actioned-heading{text-decoration:line-through double black;opacity:75%}.xfdc-actioned-discussion{opacity:50%} html body.ooui-draggbleWindow-open{position:unset;overflow:unset;margin-right:unset !important; }html body.ooui-draggbleWindow-open .oo-ui-windowManager-modal \u003E .oo-ui-dialog.oo-ui-window-active{position:static;padding:0} html body.ooui-draggbleWindow-open .oo-ui-dialog.oo-ui-window-active \u003E div{z-index:110;transition:all 0.25s ease-out 0s,transform 0s !important}  .oo-ui-textInputWidget.oo-ui-textInputWidget-labelPosition-before.padLeft2em .oo-ui-inputWidget-input{padding-left:2em !important}.oo-ui-textInputWidget.oo-ui-textInputWidget-labelPosition-before.padLeft4em .oo-ui-inputWidget-input{padding-left:4em !important} .xfdc-menuOptionWidget.oo-ui-decoratedOptionWidget{padding:7px 12px} .xfdc-taskItemWidget \u003E .oo-ui-fieldLayout-messages{clear:both} #XFDcloser-showhide{bottom:0;display:block;position:fixed;right:0;z-index:100;padding:5px;box-shadow:0 2px 4px rgba(0,0,0,0.5);background-color:#fef9e6;border:1px solid #aaa;border-radius:5px;font-size:85%}"]}];});
But if you change vector to vector-2022 or monobook or remove &version=m2csj, you get the whole script with no errors. This suggests something is wrong with the validation and/or the server caching. @SD0001: Do you have a clue why this is? Nardog (talk) 10:54, 9 February 2024 (UTC)
I was able to reproduce the issue last week but not any more. Even the load.php link you gave is returning the expected output now. The error seems to be due to server-side validation intermittently failing. Once it fails, the result is cached so it fails consistently. Changing the skin or switching to beta changes the context hash or cache key so the failure may go away.
I tried running the Peast validator on the script locally, but it's passing every time. – SD0001 (talk) 11:49, 9 February 2024 (UTC)
Weird, it still returns what I pasted above even if I refresh or go incognito. But I just tried accessing it through a VPN and it did return the expected result. So it may depend on the data center or CDN. Nardog (talk) 12:26, 9 February 2024 (UTC)
Interesting, when I got the error it was on Monobook. I hadn't tried any of the other skins. The WordsmithTalk to me 16:34, 9 February 2024 (UTC)

Update

I've got good news. phab:T359014 patch is written and merged, and will be deployed soon. This will likely fix this bug. May take a week to deploy though. Feel free to check the phab ticket for updates. –Novem Linguae (talk) 20:12, 6 March 2024 (UTC)

Patch will deploy on Thurs, Mar 14. –Novem Linguae (talk) 23:11, 6 March 2024 (UTC)
Plus possibly another week after that for caches to clear (Thurs, Mar 21), if they don't merge a cache clearing patch before Monday, Mar 11. –Novem Linguae (talk) 09:33, 7 March 2024 (UTC)
Anybody still getting this bug? If not, then the fix probably worked and we should OneClickArchive this section soon :) –Novem Linguae (talk) 19:36, 26 March 2024 (UTC)
I haven't seen it in the last week or so. The WordsmithTalk to me 21:15, 26 March 2024 (UTC)
It's working for me as well. Thank you and the rest of the phab pholks for fixing this. voorts (talk/contributions) 21:46, 26 March 2024 (UTC)

Bug: [Close] link not appearing.

The [Close] option is not appearing on AfD, CfD, FfD, or TfD discussions for me. I'm using Firefox 122.0.1 (64-bit) to browse, vector-2022 with dark mode, and these userscripts. voorts (talk/contributions) 19:17, 19 February 2024 (UTC)

Voorts, see #Loading problem. — Qwerfjkltalk 19:33, 19 February 2024 (UTC)

XFDcloser causing closed discussions to completely disappear

{{resolved}} I just noticed a new bug with XFDcloser: It now seems that on some pages of RFD where there are closed discussions, XFDcloser Now completely hides some of these discussions. This is quite problematic because it makes it so closed discussions cannot be reviewed; In fact, sometimes, this problem will make it so the evidence of a discussion even existing on that subpage is hard to find, unless one looks through the table of contents (provided one even shows up) or edits the page. Steel1943 (talk) 14:24, 28 April 2024 (UTC)

Could you give an example? Primefac (talk) 14:31, 28 April 2024 (UTC)
@Primefac: Wikipedia:Redirects for discussion/Log/2024 April 7. If you see the issues I described, the issues stopped happening once I disabled XFDcloser and reloaded the page. Steel1943 (talk) 14:53, 28 April 2024 (UTC)
Steel1943, you have no edits to that page. Did you have closed discussions hidden? Primefac (talk) 15:07, 28 April 2024 (UTC)
"Did you have closed discussions hidden?" Yes, and I don't know when I clicked that thing since it's in a really inconspicuous spot. Dang it XFDcloser. Steel1943 (talk) 15:11, 28 April 2024 (UTC)
Yeah, can't argue with that, though glad it's not a proper glitch. Primefac (talk) 15:28, 28 April 2024 (UTC)