Wikipedia talk:XFDcloser

Evad37 feature ideas

Moved from top of page to its own talk page section. I think Evad37 wrote these. –Novem Linguae (talk) 16:36, 15 June 2024 (UTC)

RFC: Priorities for XFDcloser development in 2022

What are the highest priority software bugs and feature requests for XFDcloser? - Evad37 [talk] 14:30, 12 January 2022 (UTC)

The backlog of bugs and feature requests as noted in the other sections of this page has built up quite a lot, especially over the past year or so while I haven't been so active on Wikipedia. Finding out what the community's priorities are would help me, as the primary author/maintainer of XFDcloser, to decide the order in which I work on issues. Note that responses here will just be one factor, with the other main factor being the scope/complexity of coding changes required. - Evad37 [talk] 14:30, 12 January 2022 (UTC)

• I really haven't been active at CfD for many months but I want to put in a word for improving support there. Closing discussions without XFDcloser dealing with the tags takes significantly longer and is one of the reasons I'm not excited to help out there. Pings to some of the most prolific closers from what I remember @Fayenatic london, Marcocapelle, and Bibliomaniac15:. --Trialpears (talk) 21:17, 12 January 2022 (UTC)

  Thanks for the ping, Trialpears. I agree that it would be nice if more support for CFD could be added, since it's a dreadfully lonely place. The main roadblock is of course that pretty much any result other than keep, no change, or no consensus defaulting to keep virtually requires the use of WP:CFD/W. For those unfamiliar with the process, after closing a CFD, we list it on WP:CFD/W, where a bot recategorizes everything according to the move/merge or uncategorizes according to deletion, and then performs the necessary pagemoves and deletions. The added layer of complexity is admittedly one of the drawbacks of the categorization system in general, which advantages working in articlespace at the expense of making categories more difficult to curate directly. Ambitiously, if XFDcloser cut out the middleman by also doing the recategorizing/uncategorizing work, we might not need CFD/W except in niche cases, but this would have to be rigorously tested to make sure things don't break. bibliomaniac15 22:02, 12 January 2022 (UTC)

  I've never tried XFDcloser, but I think it would merely save a few steps in the entries on CFD log pages alone. For reference, WP:CFDAI sets out the usual things involved in CFD closures. I usually use WP:CFDW to get a bot to process the member pages, or to post {{Old CfD}} on retained category talk pages. One benefit of using CFDW is that we have a discipline of checking backlinks to the old category name before removing an entry, in order to avoid leaving red links. But occasionally, I process a small category manually, or use WP:Cat-a-lot for some or all of the processing; or in cases requiring changes to template parameters, use WP:JWB on the member pages. – Fayenatic London 11:48, 13 January 2022 (UTC)

• Tracked in github.com
  Issue #65
  
  Probably #XFDcloser doesn't recognize RfD tag placed by page curation tool if that hasn't been resolved yet, and if that template is still being used. Steel1943 (talk) 21:36, 12 January 2022 (UTC)
• Tracked in github.com
  Issue #66
  
  I vote for #Old afd templates placed on talk pages of redirects, because I patrol for errors in talk namespace and my work queues are swamped by too many user's technical errors. Hate to see such errors generated by automated tools that pile more work on me, when if the user did the task manually, they probably would have done it correctly. – wbm1058 (talk) 14:31, 19 January 2022 (UTC)
• Tracked in github.com
  Issue #67
  
  Close DRVs please? Spartaz ^Humbug! 17:50, 19 January 2022 (UTC)
• Two functions I would find useful, though I do not know their utility to others;
  • Tracked in github.com
    Issue #68
    
    Tracked in github.com
    Issue #69
    
    A "draftify/userfy" option among results.
  • Tracked in github.com
    Issue #70
    
    In a multi-article AfD, the ability to manually add titles that the software then handles the same way it currently does; nominators sometimes don't format these correctly, leaving many pages to be cleaned up manually. Vanamonde (Talk) 18:30, 21 January 2022 (UTC)
• Reduce scope and make it easier for you to maintain; it's far too vital a tool now to overdesign its core purpose. Thanks for maintaining it. czar 00:51, 22 January 2022 (UTC)
• Reduce errors when detecting the XfD template - frequently it can't find this when relisting discussions. ― Qwerfjkltalk 20:26, 25 January 2022 (UTC)

  @Qwerfjkl. Do you have a diff for this one? Unclear which template, which deletion process (AFD, CFD, etc.), what the state of other relevant pages is (daily log page, article page, talk page), etc. –Novem Linguae (talk) 08:49, 11 June 2024 (UTC)

  Novem Linguae, this was years ago; I'm no longer active in RfD (which I think this comment is referring to). — Qwerfjkltalk 16:23, 11 June 2024 (UTC)

• Tracked in github.com
  Issue #71
  
  Tracked in github.com
  Issue #72
  
  Tracked in github.com
  Issue #73
  
  Tracked in github.com
  Issue #74
  
  I am trying it on CFDs for the first time. For a Keep outcome, it's handy, because it tags the talk pages. For a quick delete, it does the log page quickly, but that's all. For a multiple-outcome close such as Wikipedia:Categories for discussion/Log/2021 November 24#Noir writers by nationality, it prompted me to enter a lot of data e.g. target names, but used none of it, so that was a waste of time. Also, it currently requires the namespace for the target page (renaming or merging) to be typed in; this should default to "Category:" if omitted. The multiple nomination Wikipedia:Categories for discussion/Log/2021 November 24#Wikipedians by musician included one merge, and XFDcloser included the merge target in the list of categories for which it required an action to be stated, even though that one was not nominated. However, even though the gadget is therefore already able to detect target names, it did not use the nominated target as a default for a simple rename at Wikipedia:Categories for discussion/Log/2021 November 24#Category:Psychological tools. – Fayenatic London 11:19, 3 February 2022 (UTC)
  • Tracked in github.com
    Issue #75
    
    For an easy win, please add a "Quick no consensus" based on the "Quick keep". – Fayenatic London 16:05, 4 February 2022 (UTC)
  • Tracked in github.com
    Issue #76
    
    Please make it remove CFD templates from category pages after "no consensus" even if the templates were incorrectly not placed at the top of the page. (81 errors out of 82 here) – Fayenatic London 16:31, 15 February 2022 (UTC)
    • Sometimes it does not edit the category or category talk pages at all, e.g. [3] when that option was definitely selected (screenshot available on request). These actions appear to have broken in a recent update. – Fayenatic London 17:44, 4 March 2022 (UTC)
    • That seems to have been fixed. – Fayenatic London 13:54, 8 March 2022 (UTC)
  • Tracked in github.com
    Issue #77
    
    Top request: For a Keep result, please populate the Action parameter on the talk page, e.g. "rename" was needed at [4]. Although it sometimes does this, e.g. [5].
  • Tracked in github.com
    Issue #78
    
    Also, stop spurious tagging of talk pages of categories that were mentioned but not nominated, e.g. [6], [7]. – Fayenatic London 23:32, 16 February 2022 (UTC)
  • Tracked in github.com
    Issue #79
    
    Add a new Action (at least when using Custom) to replace the category page template with {{Cfd manual}}, e.g. for splits. The closer would still have to list the job at WP:CFDWM, but doing the template would be neat. – Fayenatic London 10:09, 17 February 2022 (UTC)
  • Tracked in github.com
    Issue #80
    
    Suppress the current error/warning messages for pages that are not in category/template space. (Screenshots available on request. For example, closing Wikipedia:Categories for discussion/Log/2021 December 28#American women opera singers by century generated warnings for pages in user and Wikipedia project space.)
  • Tracked in github.com
    Issue #81
    
    Reload the page when done. Or if there's a reason why some editors would not want that, give us a setting for it in Preferences.
  • Tracked in github.com
    Issue #82
    
    Update the URL in the browser's location bar to the current section, as would be the case if I had edited the section. This is so that I can copy the URL to paste into edit summaries when making manual changes. Currently, when using XFDcloser, the location bar URL does not get updated to the relevant section heading. – Fayenatic London 09:47, 18 February 2022 (UTC)
  • Tracked in github.com
    Issue #83
    
    Add support for stub templates when relisting. E.g. XFDcloser did not update the link on the template page to the discussion after this relisting. – Fayenatic London 10:05, 18 February 2022 (UTC)
  • Tracked in github.com
    Issue #84
    
    For a "Custom" CFD close, default to No automated actions, rather than removing templates and tagging talk pages. – Fayenatic London 17:37, 18 February 2022 (UTC)
• Tracked in github.com
  Issue #85
  
  Me want #Feature request: Delete TFDd template subpages or some reasonably sane implementation thereof. :^) --Izno (talk) 02:20, 15 February 2022 (UTC)

  ooooo, good point. Seconded. Primefac (talk) 14:26, 15 February 2022 (UTC)

Problem with relisting

I relisted around 7 or 8 discussions and they were removed from the 8/10/23 AFD log page but not put on to the 8/17/23 page. So, I cut and pasted them manually. But relisting happens a lot so I hope whatever problem is happening can get fixed. Thanks. Liz ^{Read! Talk!} 03:22, 17 August 2023 (UTC)

So, XFDcloser did relist discussions but to the wrong date, to August 16th even though it became August 17th UTC hours ago. Anyone else seeing this problem? Liz ^{Read! Talk!} 04:48, 17 August 2023 (UTC)

@Liz, #CfD relisting date bug?. Yes, me. — Qwerfjkltalk 09:37, 17 August 2023 (UTC)

Hello, Qwerfjkl,

Thanks for pointing this out. I wonder how often the XFDcloser developers monitor this talk page. Liz ^{Read! Talk!} 06:06, 27 August 2023 (UTC)

I have been posting here since early last year, and I don't see any one monitoring this talk page. Jay 💬 06:31, 27 August 2023 (UTC)

@Jay, @Liz, see #Relisting failure at CFD above; the sole maintainer has been inactive for a year and a half. — Qwerfjkltalk 06:37, 27 August 2023 (UTC)

I've got this page watchlisted and may jump in and write patches at some point. Just need some free time. –Novem Linguae (talk) 20:31, 27 August 2023 (UTC)

This relisting problem is still an issue. I relisted several discussions last night where the AFD discussions weren't removed from the daily log page. But the bigger problem is when XFDcloser removes the discussion from the current daily log but doesn't repost it to the future daily log so the discussion completely disappears from our AFD pages. We used to have a few editors who looked for AFD discussions that fell through the cracks like this and were never closed and they would repost them, sometimes months later. I'd say we have XFDcloser relisting problems about 1-5% of the time so it's not often but it's regular enough that I wish a developer would look into it. Liz ^{Read! Talk!} 02:36, 11 January 2024 (UTC)

The next time this happens, if y'all can provide some diffs, that would help with debugging. I'll need to copy wikicode of several pages over to testwiki to try to recreate this, and diffs would provide this wikicode. –Novem Linguae (talk) 06:55, 7 June 2024 (UTC)

Above, someone mentioned that it was relisting to the wrong log page. Below, someone mentioned that it was not relisting to any log page, or did not remove the relist from the old log page. Hmm.

Someone mentions this happens on 1-5% of relists. 1-5% of the time could be a wikicode issue (easy to fix), the log page not created yet (easy to fix), a race condition (hard to fix), or connection issues such as jQuery error http (hard to fix). –Novem Linguae (talk) 07:00, 7 June 2024 (UTC)

Empty see also section left

In this edit, the only link in a "See also" section was removed but the heading remained. Preferably, it would remove the heading in that case. ~Bobogoobo (talk) 05:37, 19 May 2024 (UTC)

XFDcloser links vanishing in old skins

Tracked in github.com
Issue #44

Hi all

About a week ago, XFDcloser has vanished from when I view AfD's. I have checked across three different computers, all of which use Google Chrome (latest version).

Have tried deactivating and reactivating through preferences, also to no avail.

I am technologically deficient in many respects so I'm sure I'm missing something obvious - has anyone else encountered this issue, or alternatively does anyone know a fix I should try?

Cheers
Daniel (talk) 21:48, 27 May 2024 (UTC)

@Daniel. Any WP:CONSOLEERRORs on pages where you expect XFDCloser to display? –Novem Linguae (talk) 01:15, 28 May 2024 (UTC)

Hi User:Novem Linguae, three it seems (tested on page Wikipedia:Articles for deletion/EcoCute (Japan)):

• This page is using the deprecated ResourceLoader module "codex-search-styles". [1.43] Use a CodexModule with codexComponents to set your specific components used: https://www.mediawiki.org/wiki/Codex#Using_a_limited_subset_of_components (anonymous) @ EcoCute_(Japan):279
• This page is using the deprecated ResourceLoader module "jquery.ui". Please use Codex instead. execute @ load.php?lang=en&modules=startup&only=scripts&raw=1&skin=monobook:12
• This page is using the deprecated ResourceLoader module "mediawiki.ui". [1.41] Please use Codex. See migration guidelines: https://www.mediawiki.org/wiki/Codex/Migrating_from_MediaWiki_UI

Do I have any idea what any of these mean? You bet I don't! Any help obviously greatly appreciated. Daniel (talk) 01:55, 28 May 2024 (UTC)

Those are just notices and arent the smoking gun i was hoping for. Thank you for checking though. –Novem Linguae (talk) 03:03, 28 May 2024 (UTC)

OK, so...I changed from Monobook to Vector (2022) and the closing buttons have reappeared (with no other changes on my part). It's a shame, cos I love Monobook (call me old-fashioned), but it seems like something with the Monobook isn't agreeing with XFDCloser. They also work in Vector Legacy (2010) and that looks similar to Monobook, so that's a suitable workaround from my perspective. Daniel (talk) 03:17, 28 May 2024 (UTC)

Daniel, there were recent changes to the header HTML for certain skins, which is probably what caused this. These changes will also be rolled out for both vectors at some point in the future. — Qwerfjkltalk 05:53, 28 May 2024 (UTC)

Hi Qwerfjkl, thanks for the update. Confirming both Vectors are working as of right now...with any luck Monobook will work nicely with XFDCloser some time in the future, although it's not a massive issue to use Vector (2010). Daniel (talk) 06:42, 28 May 2024 (UTC)

I'm able to reproduce on Monobook. This should be pretty easy to patch. The hard part will be figuring out how to test and deploy it. Looks like this tool hasn't had a patch in two years so it's unlikely the maintainer is around. I might look into this tomorrow. –Novem Linguae (talk) 10:02, 28 May 2024 (UTC)

OK, I figured it out and wrote a patch. I'll give @Evad37 a couple days to see the GitHub emails and see if they want to comment. If Evad is MIA, I have enough access to deploy this (intadmin, wikimedia-gadgets member), but would rather check with them first :) –Novem Linguae (talk) 15:17, 29 May 2024 (UTC)

I probably should have mentioned this earlier, but it's due to mw:Heading HTML changes; see also the phab ticket linked there. — Qwerfjkltalk 06:38, 30 May 2024 (UTC)

Came here to ask about this, and see there's already a fix in the pipeline. Much appreciated, Novem Linguae. Seraphimblade ^{Talk to me} 19:06, 1 June 2024 (UTC)

I just did a deployment. Should be  Fixed.

Please ping me if the deployment breaks anything. It's my first time deploying for this repo. The minified file has an unexplained -50,000 bytes. However my quick checks didn't find anything broken. –Novem Linguae (talk) 11:57, 2 June 2024 (UTC)

• Hey, I'm still having this problem. I use Monobook too and the script has vanished. Novem LinguaeThe Herald (Benison) (talk) 02:50, 8 June 2024 (UTC)

Most urgent bugs

Howdy folks. I might be interested in doing some work on this gadget. And there's like 100 sections on this page. Can you please give me a recap of what you think the most serious bugs are? So I can start to prioritize. Feel free to link to the appropriate sections above too. Thank you. P.S. Let's focus on bugs rather than feature requests for now. –Novem Linguae (talk) 02:32, 2 June 2024 (UTC)

Tracked in github.com
Issue #60

Novem Linguae, at CfD, the only major bug I've experienced is that XfDCloser can't handle nominations with >50 pages; it'll have something like "http error". This is probably due to the limit of 50 pages per API request for non-admin or bot accounts (the higher limits are 500), and XfDCloser doesn't batch requests properly. Sometimes this error causes XfDCloser to fail on the rest of the page, though this is pretty rare. — Qwerfjkltalk 11:32, 2 June 2024 (UTC)

Biggest bugs seem to be around RFD and CFD. This thread from 2022 also has some of the "best of" issues that people are experiencing. I also noticed (going through all of the threads on this page) that many of these are likely one-time issues (and a few of them actually were resolved and just not archived). I'll try to do a second pass... soonish... and tag the ones that I think were sorted out Primefac (talk) 10:45, 7 June 2024 (UTC)

Yes, Fayenatic london's comments there are pretty much all still applicable to CfD. — Qwerfjkltalk 14:32, 7 June 2024 (UTC)

@Fayenatic london's comments in #RFC: Priorities for XFDcloser development in 2022 were great. I turned each comment into a ticket just now. I also ticketized the other comments in that section. Ticketizing the big issues is a good first step to getting a volunteer developer to work on this stuff. –Novem Linguae (talk) 10:23, 11 June 2024 (UTC)

Novem Linguae, I've submitted a pull request that (should) fix this, would appreciate if you could take a look at it. — Qwerfjkltalk 20:56, 25 June 2024 (UTC)

Missing links about half the time

Novem Linguae, I probably should have mentioned this before, but:
The main bug I have is XFDCloser not loading. It fails haphazardly, so I assume the issue is a race condition with other scripts. For reference, heres what my HTML looks like with the other scripts loaded (not XFDCloser):

<h4 data-mw-thread-id="h-Category:Legendary_creatures-June_12-20240602121000" style="overflow: visible;" title="Latest: 9 days ago | 10 comments | 8 contributors" class="xfd-closed">
  <span class="mw-headline" id="Category:Legendary_creatures">
    <span data-mw-comment-start="" id="h-Category:Legendary_creatures-June_12-20240602121000"></span>Category:Legendary creatures <span data-mw-comment-end="h-Category:Legendary_creatures-June_12-20240602121000"></span>
  </span>
  <a class="copy-section-link-pilcrow" display="inline">¶</a>
  <span class="mw-editsection">
    <span class="mw-editsection-bracket">[</span>
    <a href="/w/index.php?title=Wikipedia:Categories_for_discussion/Log/2024_June_12&amp;action=edit&amp;section=6" title="Edit section: Category:Legendary creatures" class="nonimage sectionEditLink">
      <span>edit</span>
    </a> | <a class="copysectlink mw-selflink-fragment nonimage" href="/wiki/Wikipedia:Categories_for_discussion/Log/2024_June_12#Category:Legendary_creatures" role="button" title="#Category:Legendary creatures">copy</a> | <a>List discussion</a> | <span class="dropdown-container" style="position:relative; display:inline-block; ">
      <a class="dropdown-trigger" style="color: #0645AD; text-decoration: none; cursor: pointer">One click close</a>
      <span class="dropdown-menu" style="display: none; position: absolute; background-color: #fff; border: 1px solid #ddd; box-shadow: 0 2px 5px rgba(0, 0, 0, 0.1); padding: 5px; min-width: 6em; z-index: 1; left: 0px; top: 0.8em;">
        <a style="display: block; color: #0645AD; text-decoration: none; padding: 10px; margin-top: 5px; font-size: 150%" class="dropdown-item">delete</a>
        <a style="display: block; color: #0645AD; text-decoration: none; padding: 10px; margin-top: 5px; font-size: 150%" class="dropdown-item">rename</a>
        <a style="display: block; color: #0645AD; text-decoration: none; padding: 10px; margin-top: 5px; font-size: 150%" class="dropdown-item">merge</a>
      </span>
    </span>
    <span class="mw-editsection-bracket">]</span>
    <span id="FTTLink-heading-82" class="FTTLinks FTTHeadingLinks">
      <a title="Permanent link" href="#Category%3ALegendary_creatures" id="genLink-82" class="FTTGenLink" tabindex="0">
        <span class="FTTReplyLink FTTSVG FTTSVGLinkIcon">
          <span class="FTTScreenReaderLabel" data-content="Permanent link"></span>
        </span>
      </a>
      <a tabindex="0" class="FTTCmtA" onclick="event.preventDefault();event.stopPropagation();FTT.openReplyForm(FTT.PRM[82])">
        <span title="Add new comment or subsection" class="FTTReplyLink FTTSVGNewSectionIcon FTTSVG">
          <span class="FTTScreenReaderLabel" data-content="Add new comment or subsection"></span>
        </span>
      </a>
      <a tabindex="0" class="FTTSecEdit">
        <span title="Edit section" class="FTTReplyLink FTTSVGEditIcon FTTSVG">
          <span class="FTTScreenReaderLabel" data-content="Edit section"></span>
        </span>
      </a>
      <span>
        <a tabindex="0" title="Subscribe" class="FTTSubscribe FTTSVG FTTReplyLink FTTSVGBellIcon" onclick="FTT.stalkSubscribe(FTT.PRM[82],'bellicon',null,event);">
          <span class="FTTScreenReaderLabel" data-content="Subscribe"></span>
        </a>
      </span>
    </span>
  </span>
</h4>

It would be nice if XFDCloser was more robust at handling this kind of stuff. (And yes, I realise there's an open phab ticket for an API to add links to section headers). — Qwerfjkltalk 17:57, 21 June 2024 (UTC)

Sounds like the page is Wikipedia:Categories for discussion/Log/2024 June 21#Category:Legendary creatures. What skin are you using? What percent of the time does it fail? Does it fail often enough that you could disable half your user scripts, then another half, etc. to narrow it down to one user script that it's conflicting with? When it fails, are there any WP:CONSOLEERRORs? –Novem Linguae (talk) 02:39, 22 June 2024 (UTC)

Novem Linguae, Vector 2022; about half perhaps, hard to pin down; the scripts are probably WP:FACTOTUM, User:Enterprisey/copy-section-link (or something similar; I seem to have that disabled), User:Nardog/CopySectLink, and User:Qwerfjkl/scripts/CFDlister. There are no console errors. I will see if I can get a screen recording. — Qwerfjkltalk 15:22, 22 June 2024 (UTC)

I was able to reproduce using your common.js settings. I agree that it's probably a race condition. If another user script changes the HTML in that area, it could mess up XFDcloser's attempt to add its links. Might try disabling WikiNotes as a test and see if that fixes it, because that user script is putting links in the same area as XFDcloser. If that doesn't work, because I'm able to reproduce it, we know that it's something in your common.js, so you could use a bisect technique to figure out what script is conflicting. Bisecting involves commenting out half of your common.js, then seeing if that fixes it. If it does, then comment out half of that. If it doesn't, then re-enable that half and comment out the other half. And so on and so forth. You'd have to refresh a bunch of times to be sure since this is only happening like 50% of the time. –Novem Linguae (talk) 14:18, 23 June 2024 (UTC)

As typical, the issue has disappeared for now. I'll report back when it reappears. — Qwerfjkltalk 15:12, 23 June 2024 (UTC)

Novem Linguae, here's a screen recording (if it helps):

— Qwerfjkltalk 15:03, 28 June 2024 (UTC)

Thanks. I think disabling WikiNotes and seeing if that fixes it might be a good next step. –Novem Linguae (talk) 15:54, 28 June 2024 (UTC)

Novem Linguae, I'm not sure which script you're referring to by "WikiNotes". Qwerfjkltalk 17:28, 28 June 2024 (UTC)

Hmm. Not sure how I got the word "WikiNotes" into my head. I think I was referring to the pencil icon and similar icons in the CFD heading sections in V22, which I think are placed there by Factorum. So I guess my recommendation is to turn off Factorum for a bit and see if that fixes things. –Novem Linguae (talk) 18:10, 28 June 2024 (UTC)

Looks like that was the problem; I guess a 3 second delay wasn't long enough. Qwerfjkltalk 18:40, 28 June 2024 (UTC)

Excellent.

Resolved

–Novem Linguae (talk) 18:53, 28 June 2024 (UTC)

Are XFDcloser links supposed to show for RFD/TFD/etc entries that are hatted?

Are XFDcloser links supposed to show for RFD/TFD/etc entries that are hatted? Currently the links are showing in some cases. I am wondering if this is a bug, or useful behavior. –Novem Linguae (talk) 02:36, 2 June 2024 (UTC)

I figured it out. They are not supposed to show for hatted sections, relisted sections on the old page, etc. The XFDcloser links are supposed to be hidden if the XFD is already actioned. –Novem Linguae (talk) 04:27, 2 June 2024 (UTC)

XFDCloser not showing up in Vector 2010

Resolved

Tracked in github.com
Issue #63

For some reason, the regular XFDcloser options are not showing up on AFD discussions. I've uninstalled all of the programs and unselected the gadget. Then I selected the gadget again in the Preferences again but still, no options appear that would allow me to close a discussion. What's up here? Liz ^{Read! Talk!} 23:21, 6 June 2024 (UTC)

This is likely a WP:THURSDAY issue. They done broke something big in this one because it's not the only one I've seen today. Primefac (talk) 00:34, 7 June 2024 (UTC)

Also noting that this has been (properly) reported at WP:VPT. Primefac (talk) 00:35, 7 June 2024 (UTC)

Yes, I went to VPT when I realized that I was unlikely to get a response here. And yet, I did! Liz ^{Read! Talk!} 03:53, 7 June 2024 (UTC)

I'm able to reproduce. Will load up the dev version and step debug it after dinner. P.S. It's broken in Vector and not Timeless, so maybe they implemented mw:Heading HTML changes on modern skins (vector, vector-2022, minerva) today. WP:THURSDAY. –Novem Linguae (talk) 04:25, 7 June 2024 (UTC)

Should be  Fixed. –Novem Linguae (talk) 06:51, 7 June 2024 (UTC)

Looks like, thanks! Primefac (talk) 10:21, 7 June 2024 (UTC)

Links not showing up in XFDcloser beta version

I am on Vector Legacy 2010 (always have been) and the problem persists. Jay 💬 13:00, 7 June 2024 (UTC)

Link to example page? Ill try loading your common.js and see if something is conflicting. –Novem Linguae (talk) 13:30, 7 June 2024 (UTC)

I was referring to RfD. Sorry for not mentioning. I have switched to Vector 2022 temporarily until Vector 2010 is fixed. Jay 💬 05:34, 8 June 2024 (UTC)

@Jay. I am unable to reproduce at Wikipedia:Redirects for discussion/Log/2024 June 1#2023-24 Major Clubs Limited Over Tournament. I see green close, quickClose, and relist links. Can you please confirm you don't see them? Can you also please post a screenshot? Do you have any WP:CONSOLEERRORs? –Novem Linguae (talk) 10:35, 11 June 2024 (UTC)

I don't see the green close, quickClose and relist links. When I change my skin from Vector 2010 to 2022, and refresh the RfD page, I see them. When I switch the preference back to 2010, the links are no longer seen. How do I post a screenshot? I was on Edge, but tried on Chrome as well. I see console errors like

2024_June_1:547  This page is using the deprecated ResourceLoader module "codex-search-styles".
[1.43] Use a CodexModule with codexComponents to set your specific components used: https://www.mediawiki.org/wiki/Codex#Using_a_limited_subset_of_components
(anonymous) @ 2024_June_1:547
startup.js:1307  This page is using the deprecated ResourceLoader module "jquery.ui".
Please use Codex instead.
execute @ startup.js:1307
startup.js:1307  This page is using the deprecated ResourceLoader module "mediawiki.ui".
[1.41] Please use Codex. See migration guidelines: https://www.mediawiki.org/wiki/Codex/Migrating_from_MediaWiki_UI
execute @ startup.js:1307
index.php?title=User:PrimeHunter/Source_links.js&action=raw&ctype=text/javascript:36
10Third-party cookie will be blocked. Learn more in the Issues tab.

— Preceding unsigned comment added by Jay (talk • contribs)

Thanks for that. Deprecation notices aren't anything to worry about. We're looking for things like "error" and "uncaught". Here's a graphic with more details about what to look for in the console.

To take a screenshot, you press your "Prt Scn" key, open a graphics program such as MS Paint, paste it in, save it, then upload it somewhere. Third party sites like imgur.com can be good for this if you're OK with not using FOSS. If you want to upload it to Commons for FOSS reasons, then you'd want to use c:Special:UploadWizard, although there are many more restrictions due to copyright. For example, you're supposed to crop out your operating system unless it's Linux, and you're only supposed to screenshot open source browsers such as Firefox, rather than proprietary software such as Chrome or Edge.

Two useful screenshots would be 1) the RFD page (so I can verify your skin) and 2) the console (so I can look at the error messages). –Novem Linguae (talk) 11:53, 11 June 2024 (UTC)

Actually, don't worry about the screenshots. I was able to reproduce this just now. Let me dig into it and I'll get back to ya. –Novem Linguae (talk) 11:58, 11 June 2024 (UTC)

[edit conflict] No, there are no errors. I know to take screenshots, uploading them was the question. Definitely do not want to upload to Commons where it will be permanent. Same for imgur I guess. Is there a site where images are kept for a day or so and purged? That will be perfect for screenshots. Jay 💬 12:03, 11 June 2024 (UTC)

Sent you the requested screenshots. Jay 💬 18:40, 11 June 2024 (UTC)

@Jay, Hey man im josh, and The Herald:. I deployed a fix related to the beta version of XFDcloser. Can you try again and let me know if things are fixed? –Novem Linguae (talk) 00:50, 13 June 2024 (UTC)

@Novem Linguae: It's back for me, at least with desktop mode from Chrome browser on my phone. Hey man im josh (talk) 00:57, 13 June 2024 (UTC)

Yes, awesome, you are the GOAT! Jay 💬 05:30, 13 June 2024 (UTC)

Amazing. Works perfect. I just love Monobook and didn't wanna switch. Thank you and happy editing :) — The Herald (Benison) (talk) 13:02, 13 June 2024 (UTC)

July

I am using Vector 2022 and the XFDcloser options are not appearing for me. ✗plicit 23:40, 18 July 2024 (UTC)

mw:Heading HTML changes#Wikimedia wikis. I need to release another patch :( –Novem Linguae (talk) 23:43, 18 July 2024 (UTC)

 Fixed. Hotfix released. Should take effect within 15 minutes as caches clear. –Novem Linguae (talk) 00:21, 19 July 2024 (UTC)

That was quick. Thanks! ✗plicit 02:34, 19 July 2024 (UTC)

Notifying the nominator

Would it be possible to have the script automatically post a message on the nominator's talk page once a discussion is closed? There would need to be a way for nominators to disable that if it annoys them though; not sure how it could be done. Cocobb8 (💬 talk • ✏️ contribs) 20:08, 10 June 2024 (UTC)

No comment on the feature, but more than a feature discussion, I think this is about responsibility. Of all participants, I believe the nominator ought to be the most responsible in tracking the discussion and seeing where it is going. For 7-day discussions, if I was a nom, I would check daily or once in two days. As part of making the nomination, the nom would also have the relevant pages in the watchlist. Jay 💬 07:46, 11 June 2024 (UTC)

Not sure this is necessary; just to use TFD as an example, there are a few editors who nominate dozens of pages every week for relatively mundane reasons, and they likely do not need or want to know the outcome of those discussions (never mind the fact that they're probably watching the template itself and will get a notification when the discussion is closed). They don't also need dozens of talk page notices each week telling them the outcome. Primefac (talk) 01:02, 15 June 2024 (UTC)

Request to change script to use certain template

Tracked in github.com
Issue #90

I was wondering if you could make a slight modification to this script so that it uses Template:XfD relist over the redirect Template:Relist. I want to make the redirect a dab page, so any help with that script would be greatly appreciated. Interstellarity (talk) 20:01, 12 August 2024 (UTC)

@Interstellarity: For what it's worth, I'm all about having this gadget use the target instead of the redirect, but converting Template:Relist into a disambiguation page is controversial: Such a major change to the way things have been done for over a decade probably needs discussion at WP:RFD. Steel1943 (talk) 16:24, 22 August 2024 (UTC)

@Steel1943: Thanks. I might consider listing the redirect at RFD at some point, but I don't see a need right now to do it. Interstellarity (talk) 00:59, 23 August 2024 (UTC)

Relist date calculation bug

Tracked in github.com
Issue #91

Hello, whomever watches this talk page,

I'm using XFDCloser and, for some reason, when I relist a discussion from the AFD daily log for August 6th, it gets posted on Wikipedia:Articles for deletion/Log/2024 August 12 instead of Wikipedia:Articles for deletion/Log/2024 August 13 even though it is almost 04:00 UTC, well into August 13th. This isn't the first time this has happened but it usually gets resolved after an hour or two into the new day. Any assistance or suggestions would be welcome. Liz ^{Read! Talk!} 03:54, 13 August 2024 (UTC)

This is likely a user-side issue rather than a tool issue; I've had that before when not in UTC itself. Primefac (talk) 11:51, 13 August 2024 (UTC)

Can you link an example please? Also, what is your time zone? If you're comfortable giving it out. –Novem Linguae (talk) 12:48, 13 August 2024 (UTC)

I can give one myself, Special:Diff/1235376090 and Special:Diff/1235376112. I was traveling at the time; it's happened to me before and seems to occur when my local time does not match my computer time. Primefac (talk) 13:02, 13 August 2024 (UTC)

TFD/FFD relist wikicode

Hi, I don't use XFDcloser so sorry if this makes no sense. Recently I was confused by a line looking like this:

Relisted on 01 Jan 1901.

but with all the other links around I never thought that the way to go to the relisting was to click on the date. A wikilink text should say what the link will go to, but this one does not. So I propose that it instead should look like one of these:

Relisted on 01 Jan 1901.

Relisted on 01 Jan 1901.

Note that these link to the same place but now it says that the relisting is there whereas it didn't before. Perhaps this comment applies to other things too; I don't know. Thanks for considering. Zero^talk 13:00, 25 August 2024 (UTC)

Got a diff? There's a lot of different xfd log pages and I want to make sure we're talking about the same one. –Novem Linguae (talk) 13:53, 25 August 2024 (UTC)

I believe it is content such as Wikipedia:Templates for discussion/Log/2024 July 30 § Template:Move topicon. Primefac (talk) 14:24, 25 August 2024 (UTC)

Yes, that's it. In my case it was an image, but same idea. Zero^talk 14:50, 25 August 2024 (UTC)

OK, I'm glad I asked. This appears to be TFD only. For example RFD has a different look and different templates for its relists. I found the TFD manual relist instructions, which are at Wikipedia:Templates for discussion/Closing instructions#Relisting. Can the change you're asking for be made in one of those templates, or do we think it's hard-coded into XFDcloser? Here's some other templates that may be involved in relisting TFDs: https://github.com/wikimedia-gadgets/xfdcloser/blob/077d0b2f4f8d03cc9d20526f9cc7bbde3050fe26/xfdcloser-src/Venue.js#L170-L177. –Novem Linguae (talk) 15:34, 25 August 2024 (UTC)

{{Tfd top}} doesn't format anything, notice that in #Closing the discussion the full close is input as a parameter. I suspect XFDC (and probably Doug's old extension which I still use occasionally) just used that logic as well. I am still thinking about whether I think this is a helpful change vs changing a well-used and long-standing format/convention. Primefac (talk) 16:05, 25 August 2024 (UTC)

We could try using clearer wording. For example, changing the current wording of

The result of the discussion was relisted on 2024 August 6

to

The result of the discussion was relisted (please see the 2024 August 6 TFD discussion page)

Bummer that it's not controlled by a template. That makes this harder to change. Perhaps too hard to be worth it. –Novem Linguae (talk) 16:15, 25 August 2024 (UTC)

It's not only TFD. Here is an FFD example. Zero^talk 00:55, 26 August 2024 (UTC)

Add draftify result?

Tracked in github.com
Issue #68

Can I firstly say, thank you so much Novem Linguae for all your work with patching and bug investigating over the past couple of months - you are an unsung hero!

This is a very greedy wishlist request but I was wondering if there was capacity at some point in the future to add "draftify" as one of the results for AfD? It seems to be a reasonably common outcome nowadays and, while it is eminently achievable by using "custom" and then actioning all the page moves etc., would be amazing for it to be all bundled up. Fully understand if not possible though, or not a priority given everything else happening.

Cheers, Daniel (talk) 13:05, 28 August 2024 (UTC)

Looks like Vanamonde93 already requested this back in 2022. Ticket. I'll slap a high priority tag on it since it is now requested by multiple people. (This just means that if a volunteer dev ever sits down to work on tickets, hopefully they consider prioritizing it. There's no active development at the moment.) By the way, can you go into a bit more detail about the "extra steps" for drafts? Is the only extra step moving the page to the draft namespace, or are there other steps? Thanks. –Novem Linguae (talk) 13:19, 28 August 2024 (UTC)

It's late here but to my memory, click 'custom' > type "draftify" > close > go to article > move article (and tick 'move talk page' and 'do not leave redirect') > comment out categories on draft page (could be automated?). The bot adds the 'draft from mainspace' template afterwards. Might be something else? Daniel (talk) 13:25, 28 August 2024 (UTC)

I feel like a slight tweak of this would actually make it more useful across more circumstances. For example, at TFD there are (not super-often) "userfications" made to templates, where the template is moved to a userspace, similar to a draftification at AFD. It might be worth having a generic "move" option in the closer options, where the closer can choose the new name of the page (e.g. "Example -> Draft:Example" or "Template:Example -> User:Joe/Template:Example") which could do the move-without-redirect. I do recognise that moving pages is a bit more involved than just editing or deleting pages, so if that sort of expanded functionality is too much, then I guess I'll just have to live with it! Primefac (talk) 13:34, 28 August 2024 (UTC)

Seems like there could be 3 additional modes to add here: AFD draftify, AFD userfy, and TFD userfy. Any others? I'm not sure a move feature would be as useful for things like CFD, RFD, and FFD. Draftify has enough unique stuff going on (turning off categories, adding Moved Draft template) in it that it may make sense to keep it separate. There's also some positives to pre-programming the correct terminology in. For example "draftify" would probably be better to write in an AFD close than "move to Draft:X". –Novem Linguae (talk) 13:57, 28 August 2024 (UTC)

Allow non-admins to close CFDs

Tracked in github.com
Issue #92

Hi! I have an easy (I think?) request: Like at WP:TFD, non-admins are permitted to close discussions at WP:CFD as delete (see WP:NACD for the official guideline saying deletion NACs at CFD are okay). Would it be possible to enable this option for non-admins at CFD, like how it is enabled at TFD? Thanks, HouseBlaster (talk • he/they) 23:18, 20 September 2024 (UTC)

@HouseBlaster. Are there any CFD workflows that would change by not having the delete button? For example, for non-admins, maybe instead of trying to delete the page, the gadget would instead need to add the page to a queue / holding cell?

If the admin vs non-admin CFD workflows are the same, this is easy. If the workflows are different, this is hard. –Novem Linguae (talk) 23:12, 23 September 2024 (UTC)

@Novem Linguae: the workflows are identical at this stage in the process: XFDC only closes the discussion, and nothing else – not even deleting the page. Non-admins list their closures at WT:CFDW, but that is facilitated by a separate script (User:Qwerfjkl/scripts/CFDlister). Admins have to list the discussions directly at WP:CFDW, but that is not handled by XFDC. HouseBlaster (talk • he/they) 23:34, 23 September 2024 (UTC)

Oh, besides the fact that NACs should get tagged with {{subst:nacd}}. Otherwise identical. HouseBlaster (talk • he/they) 23:50, 23 September 2024 (UTC)

Nomination for merger of Template:Rfd-NPF

Template:Rfd-NPF has been nominated for merging with Template:Redirect for discussion. Watchers of this page are invited to comment on the discussion at the template's entry on the Templates for discussion page. Thank you. Steel1943 (talk) 22:16, 22 September 2024 (UTC)

I don't see this template in XFDcloser's code. Probably no action needed here. –Novem Linguae (talk) 23:23, 23 September 2024 (UTC)

@Novem Linguae: You are correct, it is probably not; however, this template does appear on redirects tagged by PageTriage, and as hinted above in the top section of this talk page, XFDcloser is not able to remove these tags from redirects after their respective RFD discussions have been closed. Steel1943 (talk) 17:31, 24 September 2024 (UTC)

XFDcloser creating erroneous edit summaries and linking to Undefined after AfD/PROD closures

Tracked in github.com
Issue #93

Long story short, see this diff and the clearly erroneous link to Undefined. This is one diff of many I found with the same issue, but I think only one needs to illustrate the problem. Steel1943 (talk) 16:16, 23 September 2024 (UTC)

@Steel1943. Have you noticed any pattern to this (for example links with spaces, links in a certain namespace, etc.), or does it always happen when XFDcloser removes any wikilink? –Novem Linguae (talk) 23:08, 23 September 2024 (UTC)

@Novem Linguae: Looking through some more recent edit summaries that include the link to undefined, it seems that this link is only caused by delinking pages that have been deleted through the PROD process, not AfD (contrary to what I originally assumed), and happens in title with or without spaces (from what I saw). The only way I was able to figure this out is because Explicit does a good amount of deletions, so I was able to see this pattern. (Explicit, thank you for all that you do; sorry this tool has not been working correctly and makes your PROD article delink edit summaries look wrong.) Steel1943 (talk) 17:36, 24 September 2024 (UTC)

@Primefac: To answer your since-removed comment since you make a good point that I was not aware of myself until you made the comment, it seems that the deletion itself is performed by Twinkle (see Animal Behavior Society), but XFDcloser does the delinking of the page deleted via PROD. Does that mean that Twinkle and XFDcloser interface with each other when both are enabled? (Not sure, and I'm not sure who would know.) Steel1943 (talk) 17:24, 25 September 2024 (UTC)

They are probably independent of each other. An undefined in XFDcloser's edit summary is almost surely a bug in XFDcloser, not Twinkle. –Novem Linguae (talk) 20:50, 25 September 2024 (UTC)

@Novem Linguae: I definitely agree and understand that it is XFDcloser causing the error with the delinking edit summary problems. However, the timestamps for the PROD deletion of Animal Behavior Society (Twinkle) and the delinking of a link to it in another article (the diff in my initial statement [XFDcloser]) are identical. This leads me to believe one of the following: 1) Twinkle has an option built into it to perform delinkings with XFDcloser after a PROD, thus meaning XFDcloser is not sure what to link as a result, or 2) the issue may be caused by user error, possibly by running Twinkle and XFDcloser almost simultaneously. Steel1943 (talk) 21:04, 25 September 2024 (UTC)

I see. I've added https://github.com/wikimedia-gadgets/xfdcloser/issues/93#issuecomment-2375372798 to remind myself or whoever to investigate this more when the ticket is being further researched. –Novem Linguae (talk) 22:24, 25 September 2024 (UTC)

I've cross-posted to WT:TW to see if it's an issue on their end. Primefac (talk) 12:04, 26 September 2024 (UTC)

The bug is not related to Twinkle. PROD deletions are only supported in Twinkle, and although Twinkle has its own Unlink tool, XFDC's unlinking is more feature-rich, so many users tend to prefer that – you can see the option on any non-existing page under "Tools" (vector-2022) or in the "More" dropdown (vector-2010). – SD0001 (talk) 18:12, 26 September 2024 (UTC)

the issue may be caused ... possibly by running Twinkle and XFDcloser almost simultaneously I don't think so, it's also been known to occur when you unlink 3 months after the page was deleted. – SD0001 (talk) 18:16, 26 September 2024 (UTC)

But... you can't even use XFDC if you're not on an XfD page... Primefac (talk) 18:20, 26 September 2024 (UTC)

You can. – SD0001 (talk) 18:33, 26 September 2024 (UTC)

Based on all that has been stated so far, seems both of my assumptions are incorrect and the examples that I provided from Explicit show that they are a fast clicker and that the two gadgets do not technically interrupt each other, meaning this probably has nothing to do with Twinkle. But, it seems there may be a new theory here: Do links to undefined in edit summaries only occur via the "XFDC Unlink" option when the respective page is deleted before running "XFDC Unlink"? Steel1943 (talk) 18:46, 26 September 2024 (UTC)

I tried to test this by adding a wikilink to a non-existent page to my sandbox and to a mainspace redirect. I couldn't get the XFDC Unlink tool to remove them. I don't really want to add a test link to a live article, so might be hard to test this. Might need to install the gadget on testwiki and mess around with it there to do it properly.

Anyway, I've updated the ticket with the latest hypothesis: https://github.com/wikimedia-gadgets/xfdcloser/issues/93

Also, I wonder why we don't have a mainspace sandbox. Would make certain kind of tests much easier. Maybe we could hard-code it into MediaWiki to always noindex it. –Novem Linguae (talk) 20:47, 26 September 2024 (UTC)