Template talk:Series overview

Latest comment: 7 days ago by Favre1fan93 in topic Template-protected edit request on 24 June 2024
WikiProject iconTelevision Template‑class
WikiProject iconThis template is within the scope of WikiProject Television, a collaborative effort to develop and improve Wikipedia articles about television programs. If you would like to participate, please visit the project page where you can join the discussion. For how to use this banner template, see its documentation.
TemplateThis template does not require a rating on Wikipedia's content assessment scale.

Unknown parameters check

edit

Please add a module to check unknown parameters to this template. I made a list of parameters + regular expressions for all cases, which should cover ~98% of cases. I have already checked this list in Russian wikipedia and fixed about a dozen errors. There may be some unusual cases that will also need to be added to the exceptions or otherwise corrected in the articles. (Perhaps the list of expressions itself could be simplified somewhere).

{{#invoke:check for unknown parameters|check
| unknown = {{main other|[[Category:Pages using series overview with unknown parameters|_VALUE_{{PAGENAME}}]]}}
| ignoreblank = 
| preview = Page using [[Template:Series overview]] with unknown parameter "_VALUE_"
| showblankpositional = 1
| allreleased | caption | country | dontclose | id | multiseries | network | network_transclude | released | seasonT | series | seriesT | width
| regexp1 = aux[%u]
| regexp2 = aux[%u][%d]+[%u]?
| regexp3 = color[%d]+S?[%u]?
| regexp4 = end[%d]+S?[%u]?
| regexp5 = episodes[%d]+S?[%u]?
| regexp6 = info[%u]
| regexp7 = info[%u][%d]+S?
| regexp8 = info[%u]_transclude
| regexp9 = linkR[%d]+S?
| regexp10 = linkT[%d]+S?[%u]?
| regexp11 = link[%d]+S?[%u]?
| regexp12 = network[%d]+[%u]?
| regexp13 = postaux[%u][%d]+[%u]?
| regexp14 = postaux[%u]
| regexp15 = start[%d]+S?[%u]?
| regexp16 = aux[%u][%d]+[%u]?span
| regexp17 = info[%u][%d]+span
| regexp18 = info[%u]span[%d]+S
| regexp19 = network[%d]+[%u]?span
| regexp20 = postaux[%u][%d]+[%u]?span
}}

Solidest (talk) 23:13, 4 March 2024 (UTC)Reply

Added. Gonnym (talk) 06:07, 5 March 2024 (UTC)Reply
Thanks! I'll clean up some of them and add to the list later on. Solidest (talk) 11:24, 5 March 2024 (UTC)Reply
|part= (with number and special ability) needs to be added to this. - Favre1fan93 (talk) 21:17, 5 March 2024 (UTC)Reply
Also some stuff with |network= with numbers, "S" and letters. See List of The Office (British TV series) episodes as an example. - Favre1fan93 (talk) 21:47, 5 March 2024 (UTC)Reply
Thanks, I've been collecting all the cases too. So here's the final update, 7 & 12 to replace, and 21 to add:
| regexp7 = info[%u][%d]+S?[%u]?
| regexp12 = network[%d]+S?[%u]?
| regex21 = part[%d]+S?
The only problem left is with the Talking Tom & Friends article, which I think needs to be fixed in the module code rather than added to the tracking. I will write about it a bit later. Solidest (talk) 00:15, 6 March 2024 (UTC)Reply
Added fixes to template. Gonnym (talk) 08:58, 6 March 2024 (UTC)Reply

Strange triggering of invalid parameters

edit

In some cases, parameters with a dot at the end show results instead of being treated as an unknown param: 1, 2. All of these cases displayed the data in the table. And also "episode2s" treated and worked here as "episodes2": 3 . Solidest (talk) 00:32, 6 March 2024 (UTC)Reply

The code here (line 136) is the problem it seems:
local str, num, str2 = string.match(k, '([^%d]*)(%d*)(%a*)')
This ignores the period at the end.
A testcase:
k = "infoB3."
local str, num, str2 = string.match(k, '([^%d]*)(%d*)(%a*)')
print(str)
print(num)
print(str2)
prints "infoB" and "3". "str2" is empty here.
Then at line 149 it adds the variable it found (without the period) to the new list.
SeasonEntries[num][str .. str2] = v
Gonnym (talk) 09:28, 6 March 2024 (UTC)Reply

Accessibility Issues

edit

Hi, I currently have an episode list at WP:FLC. A reviewer brought up the fact that this template isn't screen reader friendly because it uses "col" rather than "colgroup" in the headers. Is this something that can be easily fixed? TheDoctorWho (talk) 19:58, 15 June 2024 (UTC)Reply

As stated at the FLC nomination, this is hardcoded into the template that is used on over 8,000 articles, multiple of which have passed FL. I see no reason why this needs to change. Tagging MPGuy2824. -- Alex_21 TALK 00:46, 16 June 2024 (UTC)Reply
No comment on the FLC nom, but I don't see any issue with adjusting this. It shouldn't alter any other instance, and would be an overall positive I believe for the template. Nothing wrong with updating to meet proper accessibility standards/guidelines. - Favre1fan93 (talk) 15:30, 16 June 2024 (UTC)Reply

Template-protected edit request on 24 June 2024

edit

Please do the changes changes made to this module's sandbox to the main module. This is more right from an accessibility perspective. -MPGuy2824 (talk) 07:45, 24 June 2024 (UTC)Reply

  Done. @TheDoctorWho: this should be address now if you need to go back to your FLC about it. - Favre1fan93 (talk) 17:43, 24 June 2024 (UTC)Reply