Archive 5Archive 8Archive 9Archive 10

Module:Portal/images/c/sandbox

A request at Wikipedia:Requests for page protection/Decrease#Module:Portal/images/c/sandbox points out that a sandbox should not be protected, and it only has 2 transclusions. Strangely, the sandbox was WP:ECP protected on 3 January 2022 by MusikBot II which claimed there were 3203 transclusions. Does anyone know a reason for that? Is there a reason the sandbox should not have the protection removed? Johnuniq (talk) 08:02, 7 January 2022 (UTC)

I suspect that something which uses Portal/images/* was tested using Portal/images/*/sandbox and inadvertently released without removing the suffix, then corrected. I can't spot any candidates; Related Changes is too busy to be useful. I don't think User:MusikBot II/TemplateProtector reverts itself in such circumstances. Certes (talk) 12:03, 7 January 2022 (UTC)
@Johnuniq: That was probably my fault. Turning on/off the sandbox used to be more onerous, and I messed it up doing an edit. I've made it much less onerous now (making it a single boolean variable). Please remove the protection. — hike395 (talk) 15:51, 7 January 2022 (UTC)
I hate having any difference between the main and sandbox modules. Have you seen a technique like this:
local sandbox = frame:getTitle():find('sandbox', 1, true) and '/sandbox' or ''
That makes sandbox a variable which can be appended where needed. It needs tweaking when used at another project where a different name is used for sandbox. Johnuniq (talk) 23:07, 7 January 2022 (UTC)
  Done Excellent idea, now implemented. — hike395 (talk) 16:54, 12 February 2022 (UTC)
The number of transclusion is now claimed to be 593 and it's now protected again (I use WhatLinksHere and found out there are only 30 tranclusions) Thingofme (talk) 04:29, 22 June 2022 (UTC)
We should add */sandbox, */testcases to the bot's ignorelist (sandboxes should not be protected) Thingofme (talk) 04:31, 22 June 2022 (UTC)
I've requested unprotection of most protected portal-related module sandboxes. I've excluded Module:Portal/sandbox and Module:Portal bar/sandbox, as WhatLinksHere claims that they are used by live modules. Certes (talk) 10:43, 22 June 2022 (UTC)
But should we add */sandbox, */testcases to the bot's config pages (sandboxes should not be protected)? Thingofme (talk) 13:50, 22 June 2022 (UTC)
A good question. Almost all pages called */sandbox and */testcases should be unprotected. However, that's because they're linked only from small numbers of obscure pages, not because their names end in /sandbox. We try not to release anything that affects many reader-facing pages and uses a sandbox but, if it does happen, we probably want that sandbox to be protected temporarily until the underlying problem is fixed. Certes (talk) 18:13, 22 June 2022 (UTC)
Sometimes when deploying the new module to the template people mistakenly called the sandbox version, so the sandbox is temporarily high-use for a while. Sandboxes may also be protected when a lot of people use it wrongly, template sandboxes are not normal sandboxes as we may only test features/bugfix of the template. Thingofme (talk) 08:31, 23 June 2022 (UTC)
Perhaps the bot should unprotect templates and modules which drop below its threshold. Not just below, or it would be protecting and unprotecting daily as use fluctuated, but maybe below 50% of whatever the current usage limit is. The only problem I see is a cunning vandal removing the links, waiting for unprotection and reinstating them, but that should be spotted and would be much more work than doing similar damage in other ways. Certes (talk) 09:45, 23 June 2022 (UTC)
Maybe should not be unprotected (some are high-risk in many other ways like substituted frequently or used in system messages) Unprotection should be managed manually. Thingofme (talk) 13:13, 27 June 2022 (UTC)
Good point. I meant only templates protected by the bot, but even they might now require protection for other reasons too. We don't have a reliable list of templates protected only because of high usage. Certes (talk) 14:00, 27 June 2022 (UTC)
Like template protection is only used for templates solely protected for high-use, but for templates used in sensitive page or highly-viewed pages, or system message these templates should be fully protected. Thingofme (talk) 02:13, 28 June 2022 (UTC)
Also, I moved this discussion to Wikipedia talk:High-risk templates#Should */sandbox, */testcases be unprotected for further discussion. Thingofme (talk) 02:16, 28 June 2022 (UTC)

Template-protected edit request on 29 June 2022

[[File:Nissan-logo.svg]] was deleted from commons 26 June 2022 - suggest using File:Nissan logo.svg KylieTastic (talk) 10:28, 29 June 2022 (UTC)

  Done. P.I. Ellsworth , ed. put'r there 18:12, 29 June 2022 (UTC)

Template-protected edit request on 16 July 2022

Hi, File:CharlestonWVseal.gif was deleted from commons 09:29, 5 July 2022 - suggest changing to File:Flag of Charleston, West Virginia.svg  . Cheers KylieTastic (talk) 12:26, 16 July 2022 (UTC)

  Donehike395 (talk) 12:48, 16 July 2022 (UTC)

Template-protected edit request on 5 September 2022

Rename:

  Donehike395 (talk) 19:31, 5 September 2022 (UTC)

Discussion of where to place Template:Portal bar

A discussion of where to place {{Portal bar}} in articles is now open at WT:MOSLAYOUT. Please feel free to join the discussion! — hike395 (talk) 19:41, 18 September 2022 (UTC)

Use of "Johnny-automatic-scales-of-justice.svg"

Is it a deliberate satire? ("Portal of Prejudice", via the slanted scales) - MasterQuestionable (talk) 15:58, 30 June 2022 (UTC)

To editor MasterQuestionable: could be. That image was uploaded in early 2016 and then applied to the portal template with this edit. The user who changed it from File:Scale of justice 2 new.jpeg, editor CFCF, is no longer very active on Wikipedia. He probably just wanted to change from a .jpeg image to a .svg. You could be right though.   - P.I. Ellsworth , ed. put'r there 14:30, 1 July 2022 (UTC)
@MasterQuestionable and Paine Ellsworth: The current icon is borderline offensive (IMO). How about this?
hike395 (talk) 13:08, 16 July 2022 (UTC)
Best by far imho is File:Scale of justice 2 new.jpeg   Problem is, it's a .jpeg and probably needs to be converted to a valid .svg file. Seems to be the trend on Commons, anyway. - P.I. Ellsworth , ed. put'r there 13:24, 16 July 2022 (UTC)
@Paine Ellsworth: I could convert it to a gif, which makes low-byte-count icons, no problem. I just don't think it looks very good, see new icon above. The lines are too thin, and the scales are too close to the base.
Later: I found an SVG icon that was similar to File:Scale of justice 2 new.jpeg, but with thicker lines and more whitespace. Here's a comparison of the three proposals: Lady Justice, jpeg scales, svg scales:
(Lady Justice)
(Ellsworth suggested scales)
(newly found SVG scales)
Later: I updated the live portal template to use the SVG scales. We can easily change if there is disagreement. —hike395 (talk) 02:12, 18 July 2022 (UTC)


	Hope you wouldn't mind this somewhat off-topic discussion:

	[ Quote Paine Ellsworth @ CE 2022-07-16 13:24 UTC:
https://en.wikipedia.org/?diffonly=1&diff=prev&oldid=1098571121
	Seems to be the trend on Commons, anyway. ]
<^>	The trend is?..

	----

	To Hike395, would you mind me merging (and slightly reformat) your consecutive posts in the section? For better readability.

- MasterQuestionable (talk) 22:05, 8 August 2022 (UTC)

I guess it depends on what you'd like to do: I found your latest (22:05 8 August) a bit confusing and hard to read. How about you go ahead and munge my comments, and if I find the formatting unreadable, I will revert. —hike395 (talk) 23:04, 8 August 2022 (UTC)
	[ Quote Hike395 @ CE 2022-08-08 23:04 UTC:
https://en.wikipedia.org/?diffonly=1&diff=prev&oldid=1103233072
	go ahead, but I may revert ]
<^>	Of course, feel free to do it.

	[ Quote Hike395 @ CE 2022-08-08 23:04 UTC:
https://en.wikipedia.org/?diffonly=1&diff=prev&oldid=1103233072
	I found your latest (22:05 8 August) a bit confusing and hard to read. ]
<^>	I'm looking for linguistic reviews on the formatting.
	If you have the interest, please leave further details on my talk page. Thanks.
- MasterQuestionable (talk) 01:46, 10 August 2022 (UTC)
To editor MasterQuestionable: the trend on Commons is to convert files to the .svg format when possible. That has several benefits over other formats like .jpg/.jpeg, .gif or .png. - P.I. Ellsworth , ed. put'r there 07:38, 9 August 2022 (UTC)
FWIW, I think the superiority of SVG over GIF is highly overstated on WP. With the current software, SVG files get thumbnailed as PNG, so they produce larger downloads, even if the original SVG is much smaller than PNG or GIF. —hike395 (talk) 08:42, 9 August 2022 (UTC)
Preparing for the future, supposedly. - MasterQuestionable (talk) 01:46, 10 August 2022 (UTC)


Probably somewhat off-topic, but it appears that it has been a long tradition of using slanted scales for such purposes... [ https://en.wikipedia.org/wiki/Template:User_NPOV?oldid=873750989 ] - MasterQuestionable (talk) 13:44, 21 September 2022 (UTC)

Template-protected edit request

Could we update the chess icon from Nuvola apps package games strategy.png to Chess.svg ? Pretty much every other chess templates uses the svg version. Mason (talk) 23:40, 22 October 2022 (UTC)

What's with that weird black band across the bottom of the chess pieces in File:Chess.svg? — hike395 (talk) 23:48, 22 October 2022 (UTC)
  Done I fixed the SVG, and now   Chess portal uses it. — hike395 (talk) 13:08, 23 October 2022 (UTC)

Edit request 19 November 2022

Request: icons be added to Portal:Music and Portal:Rock music

Diff: [1]

DaydreamBelizer (talk) 22:35, 19 November 2022 (UTC)

This request affects Module:Portal/images/m and Module:Portal/images/r (their talk pages redirect here). Requested images are File:Gclef.svg for Portal:Music and File:Guitar_1.svg Portal:Rock Music. Certes (talk) 22:52, 19 November 2022 (UTC)
My thanks to Certes for their assistance. I did not notice before that File:Gclef.svg has a transparent background, so a similar image with a white bg (such as File:Gclef.png) would be preferable. DaydreamBelizer (talk) 02:31, 20 November 2022 (UTC)
  Done Transparent background is acceptable for portal links, so kept the svg link. — hike395 (talk) 04:22, 20 November 2022 (UTC)

Template-protected edit request on 22 November 2022

Rename:

  Done Terasail[✉️] 18:14, 22 November 2022 (UTC)

Template-protected edit request on 10 December 2022

File:Riyadh City Logo.svg was deleted from commons 5 December 2022. The file does not appear to have any uses here and there is no Portal:Riyadh any-more so the image reference can just be removed. Cheers KylieTastic (talk) 14:58, 10 December 2022 (UTC)

  Donehike395 (talk) 16:21, 10 December 2022 (UTC)

Plainlist things

I'm doing cleanup of plainlist and I see that {{portal icon demonstration}} is using the class (reasonably for its purpose). However, I also see it has code-rotted relative to the expected display (see its display in Timeless versus how {{portal}} displays particularly).

Does it make sense to support something like this as a custom module-only function supported in Module:Portal? Izno (talk) 19:37, 15 December 2022 (UTC)

Thanks for finding this. Yes, this makes sense to port to Module:Portalhike395 (talk) 07:50, 16 December 2022 (UTC)
  Donehike395 (talk) 03:26, 17 December 2022 (UTC)
This code path should probably display an error when used in mainspace. Something the old template should do/have done. this search is thankfully clear. Izno (talk) 22:04, 20 December 2022 (UTC)
  Done Good idea. — hike395 (talk) 11:41, 23 December 2022 (UTC)

Odd layout in mobile

@Izno: Do you understand why Portal boxes are full-width in MinervaNeue/mobile and not in Vector/desktop? See, e.g., [2] vs [3]. Did we break something by calling Module:List ? hike395 (talk) 03:45, 17 December 2022 (UTC)

@Izno: Apologies for the ping -- I figured it out, the tright class doesn't appear to exist in mobile. I'll fix up the background color. — hike395 (talk) 04:09, 17 December 2022 (UTC)
Yes, that would be the reason. Portal's styles need an adjustment to be a little small-resolution friendlier, but the use of the thumb classes today is useful for that reason. Izno (talk) 04:22, 17 December 2022 (UTC)
Inspired by your edits, I converted {{Portal bar}} to use flexbox about a year ago. We may need to flex-ify {{Portal}} also. — hike395 (talk) 04:41, 17 December 2022 (UTC)
To make the mobile box not be abnormally stretched, I updated Module:Portal/sandbox to use custom classes. I eliminated one layer of div which was causing the stretch. See Template:Portal/testcases (click on "mobile" to see the effects). What do other editors think? — hike395 (talk) 13:00, 17 December 2022 (UTC)
Some change or another seems to have made the #All parameters section have some different styles, I suspect your moving the color to the top level box. I do not know if that change was bad or if it should always have a background even when there is no border. Or what...
No particular other issues for the moment.
Regarding flex, we should consider the uber-small resolution pages, which may not be able to fit 175px (I doubt such a screen exists, but it's worth at least thinking about). And even for screens slightly larger, say 320px (which I think even Firefox console can emulate something that size in its default settings), now we're squishing what is likely to be text to the left into 145px. It's why Module:Side box has the styles it has. Now, we don't have to be so extreme necessarily just to account for that case, but squished text is :( and so the 100% width is generally a safer bet. (One might even entertain using that module instead.) Izno (talk) 22:03, 20 December 2022 (UTC)
@Izno: I followed your example at Module:Side box/styles.css, and made the class adaptive in the sandbox: if the width is <= 720px, then left/right disappears and the box doesn't float any more. This should prevent squashed text. — hike395 (talk) 20:37, 21 December 2022 (UTC)
See Template:Portal/testcases#Adaptive for a new test case that works with all skins. — hike395 (talk) 01:47, 22 December 2022 (UTC)
  Done Took the @media edits that Izno made, pushed it to the live CSS. — hike395 (talk) 03:19, 22 December 2022 (UTC)
Hmm, not really sure why you removed the use of the list here after looking at the numbers for transclusions of Template:Plainlist/styles.css going down and I couldn't figure out why. It was correct to use it, and any questions of CSS should have been dealt with in the context of CSS rather than removal. Izno (talk) 17:46, 22 December 2022 (UTC)
Sorry, I thought you realized what the change was from the custom classes replacing the ul, li, and span in the CSS. I had to remove the ul in order to not have the outer div grow to the entire width of the page (when screen width < 720px). That means there was no obvious place to use an output from Module:List.
Right now, the classes are very simple --- there's a table class, a table-row class, and two table-cell classes. Maybe you can force it to use Module:List by having an outer table (with max-width: 175px) with exactly one cell, and that cell can host a list (which is also display:table). I'm not sure what we gain from that extra complexity? It's not clear (to me at least) whether a user's custom CSS for a plainlist will look good in a portal box displaying as a table. It could very well be a surprise --- a user might not think that their custom CSS would apply to the contents of a portal box.
I'm open to trying to figure it out, please help me understand what you think we should do here. — hike395 (talk) 00:12, 23 December 2022 (UTC)
It's not about a user's custom CSS but instead correctly marking the list of portals up as a list and incidentally needing plainlist to do so without bullets (you can solve this problem without plainlist, it just uses all the same CSS so might as well use the plainlist CSS instead). CSS problems can be solved. I suspect the issue was that the display: table on the <ul> was not set to width: 100% and/or max-width: 100%; table display things do weird things like indeed growing out of their container when they're 'too large' (and shrinking when the size necessary for the table is smaller than its container, a property that is usually useful but in this case is likely what has caused the display grief on Timeless, come to think of it). This is one reason <table>s are bad for presentation. :) Izno (talk) 16:58, 23 December 2022 (UTC)
It sounds like you want the HTML to indicate that the portals inside the box is semantically a list. Is it enough to use a ul and set of li ? Or does it have to be a "plainlist" class? Or both? — hike395 (talk) 20:17, 23 December 2022 (UTC)
semantically a list Correct. Is it enough to use a ul and set of li ? Or does it have to be a "plainlist" class? Or both? The reason we use plainlist is to remove the bullets. You can do the same things as plainlist and put it in Portal/styles.css but that just adds CSS that's already common... in and to Plainlist/styles.css. Which just adds to page load. Izno (talk) 20:44, 23 December 2022 (UTC)
  •  Aaaaaaaaaaa
  •  Bbbbbbbbbbbb
  •  Ccccccccccc

Here's a little mockup that I made that uses Module:List and seems to work well. The box you see on the right is float right. And the version below is with no floating. It looks like it all works in mobile.

  •  Aaaaaaaaaaa
  •  Bbbbbbbbbbbb
  •  Ccccccccccc

The remaining issue is that I have to use |list_style= and |item_style= to make this work, which would require hardwiring the styles into the Lua. @Izno: would it be ok with you if I added |list_class= and |item_class= to Module:List, so that we can keep nice CSS classes that people can edit without Lua? — hike395 (talk) 20:48, 23 December 2022 (UTC)

Are you just trying to spare yourself an extra div? I don't really understand what wasn't working that made you remove the list in the first place that can't be resolved by my suggestion above to set the width to 100%. Try reverting to that version in the sandbox and adding that width. Or I can mess with it if you want. :)
In your mockups, there's no reason to add those parameters, your CSS can be (using already-provided |class=): .portalbox, .portalbox ul, .portalbox li, .portalbox-image, .portalbox-text. Izno (talk) 20:56, 23 December 2022 (UTC)
Sorry, I guess I didn't understand your width: 100% suggestions, above. Would you mind reverting the sandbox and showing me what you meant? — hike395 (talk) 21:04, 23 December 2022 (UTC)
Ok, I figured out why you were having trouble. You were relying on the behavior that divs will display when they are set to float, which is to collapse similar to how tables always are as small as they can be. When one adds the middle div, that div isn't floating, and when you remove the float at small widths, the outer div stops collapsing because the inner div is happy at 100% rather than the outer div's 175px.
Let me poke at it a bit more. The easiest way is just to set the .plainlist div to have the same max width, but I'm wondering if I can make it a bit cleaner than that. Izno (talk) 22:21, 23 December 2022 (UTC)
Would it work to do something like the mockups, above? I think we can make it work with |class=, per your suggestion. — hike395 (talk) 23:22, 23 December 2022 (UTC)
@Hike395, sure. I synced it to an older version, so you might want to sync it back to the current. The other thing I'm thinking about is that there are some thing that the module doesn't do, like roles etc, and I don't think it makes sense to add support over there for that. Izno (talk) 00:33, 24 December 2022 (UTC)
Oh, now I see what you mean about roles. Well, if you don't want to change Module:List to accept attr, I can simply change the divs to ul and li here and then we get the semantics that you want (even if we don't use Module:List or class=plainlist), with the cost of a redundant "list-style: none"
Well, I am stymied. I don't understand CSS multiple class inheritance. Maybe Izno will have better luck. I've restored the sandbox back to the live state. — hike395 (talk) 01:59, 24 December 2022 (UTC)

Success! I took the live version, converted the divs to ul and li, set list-style:none and margin:0.5em 0em ... and it worked! It doesn't use Module:List, but it does have the correct attributes and the correct ul/li semantics. @Izno: what do you think? — hike395 (talk) 02:59, 24 December 2022 (UTC)

It's a technical change to the HTML without any user-facing change (although it will likely improve the output of screen readers). I'll go ahead and make it live. — hike395 (talk) 00:08, 28 December 2022 (UTC)

Template-protected edit request on 28 April 2023

Rename:

  Question: I just removed unused images from the file, and that flag was removed --- @Rkt2312: do you see File:Flag of Omaha, Nebraska.jpg being used in a Portal box, WikiProject box, or userbox anywhere? — hike395 (talk) 05:39, 29 April 2023 (UTC)
yes, I looked on wikimedia commons. Rkt2312 (talk) 12:17, 29 April 2023 (UTC)
File:Flag of Omaha, Nebraska.jpg says it is only used in two places:
  1. User:Buaidh/sandbox, used in a test userbox that does not need to be supported.
  2. User:Kyjama, not used in a userbox
Per above, the row for File:Flag of Omaha, Nebraska.jpg is deprecated and can be safely removed from Module:Portal/images/o. There's no need to re-add it to Module:Portal/images/o or convert it to SVG. — hike395 (talk) 13:52, 29 April 2023 (UTC)
Thank you very much. Rkt2312 (talk) 18:25, 29 April 2023 (UTC)

Purge images from deleted portals?

Have a look at Template:Portal/doc/all. The vast majority of the images here are for non-existent portals. Would there be any objections if I did a mass purge of these? --Trialpears (talk) 03:39, 3 March 2023 (UTC)

Support removal: it would make the Portal module more efficient, with no loss of functionality.hike395 (talk) 05:41, 3 March 2023 (UTC)
Support but please beware that some redlinks correspond to actual portals, e.g. South africa portal refers to Portal:South Africa. In theory, the best way to do this might be a Lua change to have _displayAll check for portal names in various captialisations, but that would require more than 500 expensive function calls. Could we be more radical and fix the case once in Module:Portal/images/a etc., then have the module lowercase the text if necessary? As an aside, so few portals survived the 2019 cull that we might be able to consolidate them into one module rather than about 26. Certes (talk) 11:12, 3 March 2023 (UTC)
Whoops, Certes is correct -- we need to clean up Template:Portal/doc/all to show the correct set of portals, otherwise we will be removing images from existing portals. @Trialpears: Can you hold off for a while while we figure out how to clean this up? — hike395 (talk) 12:23, 3 March 2023 (UTC)
  Suggestion --- there may be an easier way to do a one-time cleanup without changing code in Module:Portal. Someone (Trialpears?) could download Wikiget, generate a list of all non-redirect pages in the Portal namespace, then write a little bit of code that filters the lines in all of the Module:Portal/images files, keeping only those that case-insensitively match something in the list.
I'm very busy IRL, so I wouldn't be able to get to this for a while. But it should be relatively easy to do. As an extra bonus, if we did want to fix TEmplate:Portal/doc/all, we could use this cleanup to put case-sensitive portal names into Module:Portal/images. But the cut-over to that could cause user-visible disruption. — hike395 (talk) 13:12, 3 March 2023 (UTC)
My plan was to use some regex and {{#ifexist:}} parser functions to remove all the bad rows. It's more complicated though in light of Moxy's comment. --Trialpears (talk) 16:18, 3 March 2023 (UTC)
Opposed Would this blank other templates usage??? If i am correct these images are used for more then just portals like Template:WPbox and Template:WPBannerMeta and Template:WikiProject task force box and Template:Regional notice board box.Moxy-  14:55, 3 March 2023 (UTC)
Based on this and this search it's used through portal related templates it's only used on a limited amount of portal templates, {{yytab}}, {{yyp}}, {{yywp}}, {{yynb}}, {{User WP/switch}}, {{Regional notice board box/1}}, {{WPbox/1}}, {{WPBannerMeta/templatepage}}, {{WikiProject work group box}}, {{WikiProject task force box}}. That's quite a few templates and straight up removal of all deleted portals isn't an option. I'll have a think about how to handle this. I think I may have some clever ideas to check that it's unused as well, but if that doesn't work I won't do it. --Trialpears (talk) 16:15, 3 March 2023 (UTC)
I've implemented a tracking category in the sandbox. It's a bit unconventional to not break the image, but it works as can be seen at User:Trialpears/sandbox/1. I plan to implement the category when I have time to monitor it properly. --Trialpears (talk) 12:58, 4 March 2023 (UTC)
@Trialpears: I don't think the tracking as written in the sandbox will accomplish your goal:
  • A large fraction of the deleted portals have been removed from namespace. Those will never get picked up by tracking, because you cannot add categories to template invocations that don't happen. Module:Portal already tracks redlinks invocations (see line 155) in Category:Portal templates with redlinked portals, which is mostly populated by bugs in templates less-experienced editors guessing at names of portals.
  • Conversely, this tracking isn't limited to main space, so it could pick up junk from files list Template:Portal/doc/all, which have links to lower case portals. Per Certes, those are not deleted: they never existed in the first place.
You're going to need to create the set of (All portal images) \ (Portal images that are used). The only way I know how to do that is externally to Wikipedia, using software. — hike395 (talk) 15:24, 4 March 2023 (UTC)
@Hike395 I think we're looking for different sets here. The set the tracking category is generating is the set of all pages using a portal image corresponding to a deleted portal. This set is hopefully small enough to fairly manually get the set of all unused portal images corresponding to a deleted portal which is the set that I believe should be removed. --Trialpears (talk) 20:23, 4 March 2023 (UTC)
Support removal. This is a complete joke that most of this template is deleted portals. Gonnym (talk) 16:28, 3 March 2023 (UTC)
I've made a quick and nasty hack of a report at User:Certes/Reports/Portals. It only shows the first 500 portals. Certes (talk) 18:40, 3 March 2023 (UTC)

Automated filtering

I got a first cut at automated filtering working, by parsing a database dump of all files in the Portal namespace, and using that to filter lines Module:Portal/images/a The output of the filter is Module:Portal/images/a/sandbox. Can editors check to see whether this is correct? — hike395 (talk) 21:45, 4 March 2023 (UTC)

I ran the automated script and generated all of the Module:Portal/images/*/sandbox files, PTAL. I'm going to look at the existing test cases for anything anomalous. If everything looks ok, I will promote a/sandbox to a and create a new tracking category to check for problems. — hike395 (talk) 22:33, 4 March 2023 (UTC)
You're only looking in portal space and hence missing a bunch of uses outside that namespace. Take for example the links from Albanian Regional noice board boxes. I'm generally more for finding issues before they come up than fixing afterwards, especially when working with a template used 6 million times. Do you have any issues with my tracking category or could I implement it so we can see how common usage of files associated with deleted portals is? --Trialpears (talk) 01:53, 5 March 2023 (UTC)
@Trialpears: You can go ahead and implement your tracking category. Both Module:Portal-inline and Module:Portal bar call the image() function in Module:Portal, so please check that Template:Portal-inline/testcases and Template:Portal bar/testcases continue to work.
Given that line 155 in checkPortals() is called from all three of Module:Portal, Module:Portal-inline, and Module:Portal bar, and given that function suppressed redlinks (line 164) by default in all three modules, I think you're going to find very few deleted Portals via image(), unless they are coming from {{WPbox}} or {{NBbox}} or similar.
My plan was to try to my filtering on a small fraction of Portals (like those starting with "a", or we can pick an even less common letter). I'm not tracking non-existent portals, I'm tracking the use of failure to find a portal image. When my modified lists go live and if there are a small number of extra failures, I would go and understand and fix them. If there's a large number, I would revert.
You're right that my filtering was based on a database dump of Portal space. I can also add a list of WikiProjects and Notice Boards to the "allow" list and regenerate the filtered a-z lists, and add lookup failure tracking to the image() function, too.
But there is some risk that I've screwed up and would have to revert. The downside would be some amount of time where there are extra puzzle piece portal icons when there shouldn't be. I've spot-checked my lists and they seem to be ok. (Although, as you point out, Albania got filtered out, so that's wrong).
hike395 (talk) 07:13, 5 March 2023 (UTC)
Alright, Category:Usage of portal image for non-existent portal is live and working. Looks like we're not missing anything major and if we don't remove countries and a few other random items it will be fine. We will have to wait a while for it to populate completely though. --Trialpears (talk) 14:18, 5 March 2023 (UTC)
@Trialpears: Your clever hack at line 289 of Module:Portal made me realize a much safer way of filtering the portal images. Instead of removing them of Module:Portal/images/*, we can just add |category=[[Category:Pages with deprecated portal image]] to the lines we want to remove. If those show up anywhere in WP, then we remove the category tag from the corresponding line. When that category is empty, it's safe to remove all of the marked lines, with zero user disruption.
To clarify: were you thinking that the entries corresponding to the items in Category:Usage of portal image for non-existent portal should be added to the "allow" list? — hike395 (talk) 18:36, 5 March 2023 (UTC)
I had the same thought when implementing it, but that sadly won't work because of the border parameter at line 285 would strip it. I was indeed thinking that Category:Usage of portal image for non-existent portal could be used to form an allow list or possibly split those out to form a new WikiProject image list. --Trialpears (talk) 18:43, 5 March 2023 (UTC)
@Trialpears: Line 285 is overly strict -- it should just be filtering "border", not all other arguments. I can fix to allow categorization of stored images. btw, is your use of |category= arbitrary? I don't think the image syntax looks for "category" specifically, this is just an unused parameter? Or is there something magical going on? — hike395 (talk) 15:58, 7 March 2023 (UTC)
Logically that is correct, but I'm worried that this is a scenario where the current behavior is relied upon (relevant xkcd). Ignoring |category= only wouldn't risk destroying --Trialpears (talk) 03:21, 8 March 2023 (UTC)
Fair point. I added a parser for "category=" in the sandbox at line 288, tests pass (including new tests at Template:Portal image/testcases, see "xtestx"). PTAL: if it's ok, I can make it go live. — hike395 (talk) 11:36, 8 March 2023 (UTC)
I've updated Module:Portal/images/*/sandbox to add |category=[[Category:Pages using deprecated portal images]], instead of deleting those lines directly. I added images from Category:Usage of portal image for non-existent portal to the "allow" list. Everything is ready to go live to identify any deprecated images that shouldn't be deprecated. — hike395 (talk) 11:34, 9 March 2023 (UTC)
Sorry, a lot going on and didn't have the time to check it out promptly. Looked fine but complicated. I saw you added and removed it quite quickly. Are you sure it was completly populated when removed? Category:Usage of portal image for non-existent portal took about a day to populate fully. --Trialpears (talk) 07:34, 10 March 2023 (UTC)

It looked like your tracking category was mostly populated. I used to to expand the allow list, so it's done its job. Even if it missed a few, I'm going through manually and removing the deprecated flag. So if the category wasn't fully populated, it will just cause me a little more work. Now I'm gradually moving the sandboxes to main, searching in pages for an alt flag that contains "category=" in the HTML source to find images to rescue. It's slow, but we'll get there eventually. — hike395 (talk) 09:52, 10 March 2023 (UTC)

Ready for removal

Using the idea from Trialpears, I added Category:Pages using deprecated portal image to images in Module:Portal/image/[a-z] that were unlikely to be used by any template. I then went through and found pages that appeared in that category and undeprecated the corresponding image. I did null edits on pages likely to have portal images (e.g., those in Category:WikiProject userbox galleries and Category:Location userbox galleries). I also waited a couple of weeks for the job queue to clear.

Category:Pages using deprecated portal image is now stable and small: it contains residual pages that have deprecated images. Those pages are either user sandboxes or discussions about this template itself. In the image sandboxes (e.g., Module:Portal/images/a/sandbox) I have prepared versions of the code that have the unused/deprecated images removed. You can inspect the removals by diff (e.g., [4]). If no one finds any problems and if no one objects, I'll start to gradually move these sandbox versions to the live versions over a number of days. In the end, the list of portal image icons will be cleaned up and be about half the size of the existing lists.

Please take a look and let me know! Thanks! — hike395 (talk) 20:59, 16 April 2023 (UTC)

Status:     In progress I've removed deprecated images for j-z and have not yet encountered any problems. — hike395 (talk) 18:39, 29 April 2023 (UTC)
Status:     Done Finished removing deprecated images for a-z — hike395 (talk) 05:25, 5 May 2023 (UTC)
Thanks for that and for your work on the aliases. For completeness, there are a few redundant images in Module:Portal/images/other, after some but not all of the decade portals were deleted. Certes (talk) 09:30, 5 May 2023 (UTC)
  Done I already checked --- All of the entries in Module:Portal/images/other are used at least once in WP via the _image() function outside of a sandbox, so there was no need to mark them as deprecated or remove them. You can verify by looking at the top of Template:Portal/doc/all and {{User from Åland}}.
I intend to do some further cleanup on the aliases and duplicate images, but that isn't very urgent. — hike395 (talk) 13:29, 5 May 2023 (UTC)

Template-protected edit request on 10 July 2023

Change the image for arthropods (line 112), from Cercophonius squama.jpg to Butterfly icon (Noun Project).svg. The former may be a featured picture, but at these resolutions it's an unrecognizable blob. The latter is a clean, recognizable icon.
  
Edward-Woodrow :) [talk] 19:46, 10 July 2023 (UTC)

  Not done for now: please establish a consensus for this alteration before using the {{Edit template-protected}} template. The scorpion image looks fine to me. – Jonesey95 (talk) 12:57, 11 July 2023 (UTC)
The suggested butterfly image seems much clearer to me at the low resolution available. Certes (talk) 14:07, 11 July 2023 (UTC)

Conservatism portal change

The image for the Conservatism portal has been changed seemingly without consensus. Under Module:Portal/images/c the accompanying image was changed from File:DodgerBlue flag waving.svg to File:Red flag waving.svg. This seems inappropriate as the red flag is symbolic of socialism not conservatism. Can someone who has editing privileges (I don't) please undo this edit? Kiwichris (talk) 03:32, 4 August 2023 (UTC)

  Reverted. @Buaidh: would you like to discuss why you want to make the change? — hike395 (talk) 04:13, 4 August 2023 (UTC)
The {{conservatism sidebar}} uses a blue flag. The colour is generally associated with the right wing. The U.S. is exceptional, with the more conservative main party using red and their opposition blue. Certes (talk) 09:10, 4 August 2023 (UTC)
I concur.  Buaidh  talk e-mail 20:33, 4 August 2023 (UTC)

Template-protected edit request on 23 August 2023

Add the image   for Portal:Eurovision Song Contest. This is the main symbol of the contest and logo for the Portal. Ktkvtsh (talk) 09:55, 23 August 2023 (UTC)

  Completed. P.I. Ellsworth , ed. put'er there 02:43, 24 August 2023 (UTC)

Template-protected edit request on 4 September 2023

Rename:

  Done * Pppery * it has begun... 14:16, 5 September 2023 (UTC)

Edit request 25 November 2023

For the Libertarianism portal, please change ["libertarianism"] = "2006 AEGold Proof Obv.png|link=|alt=coin", to ["libertarianism"] = "Libertarianism-groups-diagram.png|link=|alt=diagram",. The use of the coin and gold colors on libertarian-related items are leading to POV concerns as seen here and here. Wow (talk) 04:02, 25 November 2023 (UTC)

  Done, although at 28 pixels high, that image is almost impossible to understand. — hike395 (talk) 11:41, 25 November 2023 (UTC)

Edit request 29 November 2023

Description of suggested change: Add icon for portal redirect: add Flag of the United States.svg|border|link=|alt=flag for America.

Edward-Woodrow (talk) 00:07, 29 November 2023 (UTC)

  Completed. P.I. Ellsworth , ed. put'er there 22:10, 29 November 2023 (UTC)

Template-protected edit request on 2 December 2023

Hi, File:Flag of Johnston Atoll (local).svg was deleted from commons 00:29, 29 November 2023. There is no portal so this could either just be removed or replaced with File:Flag of the United States (DoS ECA Color Standard).svg per Johnston Atoll. Cheers KylieTastic (talk) 18:06, 2 December 2023 (UTC)

  Not done: Wrong page, your request should be @ Module:Portal insted. - FlightTime (open channel) 18:14, 2 December 2023 (UTC)
@FlightTime starting an edit request on Module:Portal/images/j brings you here as it does for all the sub image pages. Also Module_talk:Portal is just a redirect to here. KylieTastic (talk) 18:19, 2 December 2023 (UTC)
  Done SWinxy (talk) 23:09, 2 December 2023 (UTC)

Edit request 9 December 2023

Please change the image for Portal:Insects from File:European wasp white bg.jpg ( ) to something recognizable at these sizes – I suggest File:Beetle icon.svg ( ). Cremastra (talk) 22:36, 9 December 2023 (UTC)

The image used is determined by Module:Portal/images/i. Its talk page redirects here. Certes (talk) 00:01, 10 December 2023 (UTC)
The wasp is difficult to make out at the 20px image size. Editor Certes, do you object to using the beetle icon? P.I. Ellsworth , ed. put'er there 02:46, 10 December 2023 (UTC)
I support the requested change. The beetle looks a lot clearer than the wasp at that scale. Certes (talk) 15:59, 10 December 2023 (UTC)
  Completed{{Portal-inline|Insects}} yields   Insects portal. P.I. Ellsworth , ed. put'er there 16:15, 10 December 2023 (UTC)
Thanks a lot! Cremastra (talk) 21:57, 11 December 2023 (UTC)

Edit request 11 December 2023

Description of suggested change: Hi, I'm back...

Please change the icon for Portal:Agriculture from File:Veranotrigo.jpg, which is completely indiscernable at these sizes ( ) to... anything, really. I suggest File:Noto Emoji Oreo 1f33e.svg ( ) as symbolic and easily recognizable. Thanks, Cremastra (talk) 21:57, 11 December 2023 (UTC)

That looks like an improvement to me. The place to change it is Module:Portal/images/a. (Its talk page redirects here.) Certes (talk) 22:16, 11 December 2023 (UTC)
  Done Wow. That was completely unreadable. I did your suggestion, but there are also plenty of options at commons:Category:Wheat icons! SWinxy (talk) 01:11, 12 December 2023 (UTC)

Template-protected edit request

Add the image File:Círculos Concéntricos.svg for Portal:Vital articles, thanks.Guilherme Burn (talk) 01:07, 20 December 2023 (UTC)

  Done SWinxy (talk) 01:19, 21 December 2023 (UTC)
@SWinxy: Not works. Redundant "File:" text.Guilherme Burn (talk) 12:00, 21 December 2023 (UTC)
Whoops. Fixed. SWinxy (talk) 01:21, 22 December 2023 (UTC)

Template-protected edit request on 3 January 2024

Please change the image for Disney to File:Mickey Mouse colored.svg. 1989 (talk) 19:20, 3 January 2024 (UTC)

That's a great idea but does it display legibly at 19 pixels high?   (Old image for comparison:  .) Could we use a cropped version with just Mickey's head? Certes (talk) 20:00, 3 January 2024 (UTC)
@Certes: Here is a preview of Mickey's head:   1989 (talk) 22:58, 3 January 2024 (UTC)
Thank you. I think the head is more recognisable (without a microscope) but am happy to support either change. Certes (talk) 23:13, 3 January 2024 (UTC)
  Done File:Mickey Mouse colored (head).svg (the one added) seems slightly more readable than File:Mickey Mouse colored.svg, but a significance upgrade to File:Magic Kingdom castle.jpg. SWinxy (talk) 04:01, 4 January 2024 (UTC)

Edit request 9 January 2024

Please add the image "File:Triple-Spiral-4turns green transparent.svg" for the "  Celts portal template". Thanks

Titus Gold (talk) 02:37, 9 January 2024 (UTC)
  Donehike395 (talk) 05:34, 9 January 2024 (UTC)

Template-protected edit request on 13 February 2024

I'd like to properly request that the display icon for the "Monarchy" portal be changed from "File:Crown of Saint Edward Heraldry.svg" to "File:Imperial Crown Heraldry.svg" (which represents the Tudor Crown). Given that the Tudor Crown has replaced the St Edward's Crown as the main heraldic crown symbol of the British monarchy under King Charles III, it seems only fitting (at least in my opinion) that the Tudor Crown should replace the St Edward version as the face of this particular portal as well. Snow Lion Fenian (talk) 17:36, 13 February 2024 (UTC)

  Completed. P.I. Ellsworth , ed. put'er there 18:59, 13 February 2024 (UTC)
@Paine Ellsworth: Thank you! Snow Lion Fenian (talk) 21:44, 13 February 2024 (UTC)
Happy to help! Paine  23:48, 13 February 2024 (UTC)

Template-protected edit request on 16 February 2024

Change Chicago's portal image to Flag of Chicago, Illinois instead of the seal.

 

212.192.13.75 (talk) 07:56, 16 February 2024 (UTC)

  Completed. P.I. Ellsworth , ed. put'er there 13:42, 16 February 2024 (UTC)

Template-protected edit request on 16 February 2024 (2)

Change Philadelphia image to Flag of Philadelphia. Flags repressnt the city better than seals.

 

212.192.13.75 (talk) 07:58, 16 February 2024 (UTC)

  Completed. P.I. Ellsworth , ed. put'er there 13:42, 16 February 2024 (UTC)

Edit request 23 February 2024

Description of suggested change: replace File:Psi2.svg -> File:Greek uc psi icon.svg --Mrmw (talk) 13:33, 23 February 2024 (UTC)

Diff:

ORIGINAL_TEXT
+
CHANGED_TEXT

Mrmw (talk) 13:33, 23 February 2024 (UTC)

Is there a consensus for this change? Here's the difference:
Please link to a discussion, if any. I see that you have added this image to many pages without using edit summaries. Please use edit summaries, especially when editing template pages. – Jonesey95 (talk) 14:40, 23 February 2024 (UTC)
@Jonesey95: this file is part of new series, they are optmized and harmonized, please have a look at template on commons (see: c:Template:Other versions/Greek letters) --Mrmw (talk) 15:06, 23 February 2024 (UTC)
So no discussion, no consensus, no edit summaries? How is a template editor to know whether this is a reasonable change to make? – Jonesey95 (talk) 16:53, 24 February 2024 (UTC)
@Jonesey95: of course its resonable - i told you this file is part of new series of greek letters - do you have any questions? you can see these files at template on commons (see link above) --Mrmw (talk) 17:03, 24 February 2024 (UTC)
I looked at the link you provided, and then I asked a question that you have not yet answered. You have not provided any links showing that this is anything other than a personal project on Commons with no support beyond your own ideas about what looks better aesthetically. Another template editor may be willing to make this change on good faith, and I would not object, but I don't see a good reason to do so using my own template editor rights. Also, you continue to make edits without providing edit summaries, even after I posted a gentle warning message on your talk page. Sorry if that is frustrating. – Jonesey95 (talk) 03:23, 25 February 2024 (UTC)
  Not done for now: please establish a consensus for this alteration before using the {{Edit template-protected}} template. —⁠andrybak (talk) 00:55, 27 February 2024 (UTC)

Template-protected edit request on 22 February 2024

Please change the image of the Islam portal to this image according to the discussion on WikiProject Islam ☆SuperNinja2☆ 06:36, 22 February 2024 (UTC)

  Done ... but that is not a consensus as no one else responded, and it was only open for three days. Therefore I will revert this change on request — Martin (MSGJ · talk) 13:07, 22 February 2024 (UTC)
As there is no consensus, it should be reverted. Zsohl(Talk) 12:21, 23 February 2024 (UTC)
@MSGJ It was stated that this change would be reverted upon request, Why is it not reverted? We don't reach a consensus and it is being opposed. Zsohl(Talk) 01:37, 28 February 2024 (UTC)
  Reverted --- it looks like the discussion for change did not reach a consensus. If MSGJ wants to revert my reversion, I will defer to them. — hike395 (talk) 05:48, 28 February 2024 (UTC)
That's fine. I just didn't notice your post Zsohl until you pinged me — Martin (MSGJ · talk) 08:52, 28 February 2024 (UTC)