Talk:Viète's formula/GA1
Latest comment: 3 years ago by David Eppstein in topic GA Review
GA Review
editGA toolbox |
---|
Reviewing |
Article (edit | visual edit | history) · Article talk (edit | history) · Watch
Reviewer: Amitchell125 (talk · contribs) 08:37, 1 July 2021 (UTC)
Happy to review this article.
Review
editLead section/Infobox
|
---|
|
1 Significance
editThe link to approximating should link to both this word and π.- Done. —David Eppstein (talk) 20:49, 4 July 2021 (UTC)
- methods for approximating π to (in principle) arbitrary accuracy had long been known – seems to be in need of copy editing to improve the English’.
- The grammar seems ok to me. "In principle" is used adverbially, to modify "arbitrary accuracy". "Approximating to arbitrary accuracy" is the idiomatic choice of preposition to use. "Methods for approximating π had long been known" is a normal past-perfect sentence. What do you see as dubious here? —David Eppstein (talk) 20:47, 4 July 2021 (UTC)
- In an article that stands out for its eloquence and good use of plain English, this sentence brings me up short, probably due to the "(in principle) arbitrary accuracy" bit. Perhaps simply 'By around 2000 BC, methods for approximating π had been found by the Egyptians and the Babylonians.' (using Beckmann, p.12)? Amitchell125 (talk) 08:38, 5 July 2021 (UTC)
- But that loses an important piece of meaning. You can approximate π by saying it's 3 — that's a method for approximating π, but not one with arbitrary accuracy. And on the other hand, we can today easily find thousands of digits of π, but in Viète's time nine digits was difficult, so the ability to calculate to arbitrary accuracy came with an increasing cost to that accuracy, meaning that for practical purposes the accuracy was limited even though theoretically it wasn't. All of that is packed into the current sentence and missing from your replacement. —David Eppstein (talk) 16:24, 6 July 2021 (UTC)
- In an article that stands out for its eloquence and good use of plain English, this sentence brings me up short, probably due to the "(in principle) arbitrary accuracy" bit. Perhaps simply 'By around 2000 BC, methods for approximating π had been found by the Egyptians and the Babylonians.' (using Beckmann, p.12)? Amitchell125 (talk) 08:38, 5 July 2021 (UTC)
Who were Archimedes and Ludolph van Ceulen?- Mathematicians who did the things described here, about whom going into more detail would be off-topic. See WP:GACR #3b. —David Eppstein (talk) 20:05, 4 July 2021 (UTC)
has been noted – by anyone in particular?- Rewritten to name and linked the authors of these opinions. —David Eppstein (talk) 21:34, 4 July 2021 (UTC)
a motivating example – could you explain motivating?- It is the usual meaning of the English word: an example that motivates a reader who sees it (or maybe more accurately the author of the book cited) to look more deeply and connect this topic with a different one. More specifically, Kac goes through a derivation of the formula in which a certain system of orthogonal polynomials related to binary notation appears. He notices that, at some point in the derivation, one has a sum of products that is equal to a product of sums of the same formulas. This is a strange thing to happen (you can't normally swap the operations of sums and products like that), and Kac asks whether it's a coincidence or an example of a more general phenomenon. The more general phenomenon that he finds to explain this is statistical independence. To say all this in any more detail in the article itself would be rather off-topic, and not really helpful to readers trying to learn about the formula itself; see WP:GACR #3b. —David Eppstein (talk) 20:44, 4 July 2021 (UTC)
- Understood, and thanks for your detailed reply. Amitchell125 (talk) 09:20, 5 July 2021 (UTC)
Link circumference; polygon; Viète (his full name should be linked); explicit formula (see Explicit formula to select the correct link); wave propagation rates (presumably Velocity factor); integrals.- The first instances of perimeter, circumference, polygon, Viète, and integral are now linked. Too much repetion of those links, to the first instance in each section, might violate WP:OVERLINK. None of the disambiguation links in explicit formula (disambiguation) goes to a relevant article; the terms are used with their colloquial English meanings. Rewrote the sentence on wave propagation to try to be less technical; I think the correct wikilink there is actually dispersion relation. —David Eppstein (talk) 21:41, 4 July 2021 (UTC)
used by Archimedes to find the approximation (+ formula) needs a citation.- Added. —David Eppstein (talk) 00:42, 5 July 2021 (UTC)
Is However necessary?- Probably not. Removed. —David Eppstein (talk) 00:38, 5 July 2021 (UTC)
closely related method – I think it needs to be clear which method is being referred to here, as two are referred to in the paragraph.- Clarified. —David Eppstein (talk) 00:38, 5 July 2021 (UTC)
I would link infinite product and π, even though they are linked in the lead (see [[MOS:DL]).- Infinite product re-linked. I'm not entirely convinced that π needs even a single link, per MOS:OL "understood by most readers in context": is there any reader of this article who doesn't know what π is?
- Agreed, happy if {{pi} wasn't linked at all. Amitchell125 (talk) 09:39, 5 July 2021 (UTC)
- Well, I think it does need to be linked in the lead, but not later. —David Eppstein (talk) 16:44, 6 July 2021 (UTC)
- Agreed, happy if {{pi} wasn't linked at all. Amitchell125 (talk) 09:39, 5 July 2021 (UTC)
Copy edit the first formula of European mathematics representing a number to something like ‘the earliest formula in European mathematics to represent a number’.- Copyedited, but differently than the suggestion. —David Eppstein (talk) 00:38, 5 July 2021 (UTC)
2 Interpretation and convergence
|
---|
More comments to follow. Amitchell125 (talk) 19:35, 2 July 2021 (UTC) |
3 Related formulas
edit- more than a century later is not verified by the text? (Beckmann, p.95: “almost two centuries later”).
- In what sense do you think that it is incorrect to say "more than a century" for a length of time that a source describes as "almost two centuries"? for all sufficiently small values of . We should not be following the exact wording of the sources; that would be plagiarism. —David Eppstein (talk) 19:51, 4 July 2021 (UTC)
- Perhaps the exact year Euler obtained π (1735 I believe) would be better.Amitchell125 (talk) 12:12, 5 July 2021 (UTC)
- I'm not convinced that is the right reference. What in there looks to you like the same formula? See also [1] (unfortunately not a reliable source) where the contributors try to track down this formula to Euler, find instead a different more complicated product formula, and don't find the original formula. So because we don't know the date but we do know when Euler was active, we need to be vague. Because of the stackexchange failure to properly attribute this formula to Euler, I changed it to say "that has often been attributed to Leonhard Euler, more than a century later" (with the restoration of the Beckmann footnote, as Beckmann makes this attribution), rather than saying more definitively that it is by Euler and on what date. —David Eppstein (talk) 16:43, 6 July 2021 (UTC)
- Perhaps the exact year Euler obtained π (1735 I believe) would be better.Amitchell125 (talk) 12:12, 5 July 2021 (UTC)
Then, expressing each term of the product on the right as a function of earlier terms using the half-angle formula – this text and the following expression are not verified by Beckmann on pp. 94–95.- I sourced it to Morrison instead. (Kac also uses the same derivation but without as much detailed justification for each step.) —David Eppstein (talk) 01:29, 5 July 2021 (UTC)
4 Derivation
|
---|
|
5 References
|
---|
|
6 External links
|
---|
|
On hold
editI'm putting the article on hold for a week until 10 July to allow time for the issues raised to be addressed. Regards, Amitchell125 (talk) 19:55, 2 July 2021 (UTC)
- @Amitchell125: I believe I have addressed all of your comments above (implementing many but not all of them). Please take another look. —David Eppstein (talk) 01:30, 5 July 2021 (UTC)
- Almost done, thanks for all you've done so far. Amitchell125 (talk) 12:46, 5 July 2021 (UTC)