Talk:Pick's theorem/GA1

Latest comment: 2 years ago by Horsesizedduck in topic Final appraisal

GA Review edit

Article (edit | visual edit | history) · Article talk (edit | history) · Watch

Reviewer: Horsesizedduck (talk · contribs) 14:57, 3 July 2021 (UTC)Reply


Greetings! I'm here to review this article for GA status! It caught my attention, and I find it more interesting the more I look at it! Let's have a look! Horsesizedduck (talk) 14:57, 3 July 2021 (UTC)Reply

First Impressions edit

  • Images: spot on;
  • Sources: reliable, more investigation to follow;
  • No OR spotted;
  • Neutral point of view: nearly certain;
  • Stability: stable as it gets, nominator is also greatest recent contributor;

Will continue in a few hours, after consulting bibliography adequately and dealing with other circumstances.Horsesizedduck (talk) 16:14, 3 July 2021 (UTC)Reply

Updates edit

Save for some technical article concerns I would like to discuss with the nominator, the article seems close to passing the review. Noting the nominator has mentioned being busy today, I will take some more time before leaving instructions. Horsesizedduck (talk) 17:49, 3 July 2021 (UTC)Reply

Actually, after more careful examination, my plans have changed: the prose of the article has notable readability issues. Aside from being very dense, some sentences run rather long; the ability to discern meaning ("1a") may be compromised for the average reader, and correction in that case would involve copyediting work - not just the nominator executing suggestions by the reviewer.

Recognizing this new setback, to salvage a possibility of passing the article, I am contemplating two options, aside from (perhaps more wisely) failing it:

  • Putting up some copyedit request;
  • Calling for a second opinion, from a more experienced reviewer;

At this point, I will put the article on hold and wait for input from @David Eppstein: the nominator. Standing instructions are to improve the proofs and generalization, discussing here or in the talk page. Horsesizedduck (talk) 22:24, 3 July 2021 (UTC)Reply

Response to the initial review edit

@Horsesizedduck: This is the paradigm of a non-constructive review: Your article is bad but I'm not going to tell you anything useful about where to find the bad parts so you can fix them, and I'm not going to give you any detailed feedback on any point other than this one thing I thought was bad. Additionally, the review appears not to have understood a very important piece of wording in the GA criteria: the article should be "understandable to an appropriately broad audience". That does not mean the same thing as understandable to all audiences. It is not reasonable or within the criteria to demand, for instance, that a mathematical proof be readable to someone who does not understand mathematical proofs or who shies away from them as being too scary to read. The review's invocation of "the average reader" shows that the reviewer has missed this point; this part of the article is not aimed at "the average reader", and should not be.

It is also crucial to understand that different parts of the article are aimed at different audiences, per WP:TECHNICAL, with the more basic material earlier and the more advanced later. I think that the opening part of the article, the introduction and "formula" section, should be readable by high school students (if it isn't, it could use improvement) but that the later parts of the article are and should be more advanced.

That said, I have gone over the entire proof section, adding another illustration and splitting it into more smaller sentences. I'm not entirely convinced that it's more readable that way, but it's what you asked for. I have not done the same to the "Other proofs" section; this section is aimed at more advanced readers who might already have some idea what a Voronoi diagram or a doubly periodic function might be, rather than the target audience of the "Via Euler's formula" section (readers who are comfortable with mathematical proof in general but without much more assumption about their background knowledge).

I also (more or less unrelatedly — I was thinking of doing this anyway before seeing your review) expanded the see-also section into article prose, adding sources for it.

Please, take another look, both at the parts of WP:TECHNICAL about what an "appropriate audience" is and is not, and at the updated version of the article. —David Eppstein (talk) 01:31, 4 July 2021 (UTC)Reply

@David Eppstein:, you are entirely correct. I apologise for any distress my misunderstandings might have caused. I can only defend that my immediate thoughts were to involve someone with more insight to come assist the review.

Allow me to explain my thought process. As you noticed, WP:TECHNICAL was a part of what made me hesitate. Finding myself slightly adrift, I believed the article might not fit the criteria, and found it difficult to give proper feedback. Indeed, saying "rewrite these sections" would be absurd, and in trying to avoid saying it, I think I actually sent precisely that message across.

In response, you went above and beyond, and essentially did just that.

My feedback now is:

  • "This is the value given by Pick's formula for this triangle, but it would be circular reasoning to use Pick's formula in its own proof": Perhaps this could be turned into a footnote, with a few adjustments to the following sentence;
  • " ... contains twice as many triangles (in the limit as the scale factor goes to infinity) as the number of grid points it contains." Could perhaps be turned into "... contains twice as many triangles as grid points."
  • "Any other polygon can be subdivided by the repeated addition of line segments within the polygon between pairs of grid points, not crossing any other added line segment, until no more line segments can be added." Perhaps this could be "... can be subdivided by adding line segments between pairs of grid points within it, without crossing, until no more can be added" (Unless it's too close to the cited material)

For now this will have to do for me, as in my time-zone it is quite late. I will have more suggestions tomorrow, within 8 hours of this edit, and am confident it will be at the GA status when we're done. I am genuinely grateful for your willingness to put up with errors on my part. Wikipedia is doubtless better for it.Horsesizedduck (talk) 02:57, 4 July 2021 (UTC)Reply

Re 'Could perhaps be turned into "... contains twice as many triangles as grid points."': unfortunately no. It is not exactly twice, because of boundary effects, but those effects become smaller as the scale factor gets larger. The other two changes look possible, though. —David Eppstein (talk) 06:26, 4 July 2021 (UTC)Reply

Final appraisal edit

As it stands, the article definitely meets all criteria, and the nominator has put in a considerable amount of work (this is an understatement).

Accordingly, I will pass the article. @David Eppstein: are there any more changes you wish to make?


GA review
(see here for what the criteria are, and here for what they are not)
  1. It is reasonably well written.
    a (prose, spelling, and grammar):  
    b (MoS for lead, layout, word choice, fiction, and lists):  
  2. It is factually accurate and verifiable.
    a (references):  
    b (citations to reliable sources):  
    c (OR):  
    d (copyvio and plagiarism):  
  3. It is broad in its coverage.
    a (major aspects):  
    b (focused):  
  4. It follows the neutral point of view policy.
    Fair representation without bias:  
  5. It is stable.
    No edit wars, etc.:  
  6. It is illustrated by images, where possible and appropriate.
    a (images are tagged and non-free images have fair use rationales):  
    b (appropriate use with suitable captions):  

Overall:
Pass/Fail:  

  ·   ·   ·  
I'm happy with the article as it stands, for now. —David Eppstein (talk) 16:24, 4 July 2021 (UTC)Reply
I will give it GA status immediately. Thank you once more for an amazing contribution. Horsesizedduck (talk) 16:39, 4 July 2021 (UTC)Reply