User talk:Js/6tabs-vector.js
Protocol-relative URL edit
 | This edit request has been answered. Set the |answered= or |ans= parameter to no to reactivate your request. |
In the line that sets the src attribute of each icon image:
.attr('src','http://upload.wikimedia.org/wikipedia/'+name)
the URL should be protocol-relative, that is:
.attr('src','//upload.wikimedia.org/wikipedia/'+name)
in order to avoid mixed content in the event that someone is using the secure server without HTTPS Everywhere. Does this look right, or am I missing something? SoledadKabocha (talk) 05:28, 21 September 2012 (UTC)
- In other words, diff of the requested edit SoledadKabocha (talk) 05:03, 24 September 2012 (UTC)
Interface-protected edit request on 1 February 2021 edit
| | This edit request has been answered. Set the |answered= or |ans= parameter to no to reactivate your request. |
Currently, the accesskey attribute is copied to the links of the two tabs added by this script. Because of this, pressing <access key modifier>+t when on a content page only cycles through the view, edit, and history tabs for the talk page, instead of the normal (without this script) behaviour of navigating to the talk page. The same issue exists when you are on a talk page and want to navigate to the content page, just the other way around.
The problem can be fixed by inserting .removeAttr('accesskey') before the semicolon on line 21 (diff), which removes the attribute from the added tabs. You can test this change by loading my modified version of this script in your common.js or vector.js using {{subst:lusc|User:Rummskartoffel/6tabs-vector.js}}. If you don't normally use access keys and don't know the modifier on your browser and OS, see Wikipedia:Keyboard shortcuts#Using access keys.
After applying the change, please delete User:Rummskartoffel/6tabs-vector.js. Thanks in advance! – Rummskartoffel (talk • contribs) 15:13, 1 February 2021 (UTC)
Done @Rummskartoffel: this has been completed. — xaosflux Talk 11:06, 8 February 2021 (UTC)