Module talk:HS listed building row

Microformat

Please add hCard microformat markup, like that in {{EH listed building row}}; specifically the classes vcard, fn org, label, category, note, uid. Andy Mabbett (Pigsonthewing); Talk to Andy; Andy's edits 13:38, 26 June 2014 (UTC)

@Pigsonthewing: Partly done: I added most of them, but there didn't seem to be anywhere to add category. Also, can you make sure the output is what you expect? I haven't worked with hCard microformat before. Jackmcbarn (talk) 16:10, 26 June 2014 (UTC)

@Jackmcbarn: That looks fine; thank you. And yes, there's no suitable entry for "category" here. Andy Mabbett (Pigsonthewing); Talk to Andy; Andy's edits 16:54, 26 June 2014 (UTC)

Grid Refs and Coordinates

I tried to separate the above column into two columns, one for OS grid refs, and one for Lat/Lon co-ordinates. I don't know my way around Lua scripts well enough to succeed, so I undid the edits I made here and to Template:HS_listed_building_header. There is no good reason why two distinct items of data should be in one cell. Presenting the data in this way makes it a real PITA to copy/paste the data to a spreadsheet or CSV file. I will make the effort to learn a bit more Lua and sandbox a better solution, but if anyone else can make the edit, go ahead. Thanks. AJRussell (talk) 23:20, 5 August 2014 (UTC)

@AJRussell:  Done Jackmcbarn (talk) 02:21, 6 August 2014 (UTC)

@Jackmcbarn: You legend. Thanks very much. AJRussell (talk) 10:24, 6 August 2014 (UTC)

Line 26 calling parserfunction

Hi, the current revision I'm seeing calls a parser function at line 26, i.e. frame:callParserFunction('#coordinates', {args.lat, args.lon, name = delinkedName}). Wouldn't it be safer to wrap it in a pcall instead?

local success, result = pcall(mw.ext.ParserFunctions.coordinates, {args.lat, args.lon, name = delinkedName})

Just a comment about safety, because I was working on improvement on Module:Roman. Before Special:Diff/717026907/717124504, some templates could not recognize the existence of #expr and was failing. Similarly, there have been edit requests suggesting similar pcall changes. I'm currently holding off on this, as I see this module's already been put in place for about 2 years already. — Andy W. (talk · contrib) 03:24, 26 April 2016 (UTC)

@Andy M. Wang: The #expr parser function is special. Most parser functions (including #coordinates) can't be called via mw.ext, so this wouldn't work at all. Jackmcbarn (talk) 03:27, 26 April 2016 (UTC)

Requested move 8 November 2019

The following is a closed discussion of a requested move. Please do not modify it. Subsequent comments should be made in a new section on the talk page. Editors desiring to contest the closing decision should consider a move review after discussing it on the closer's talk page. No further edits should be made to this discussion.

The result of the move request was: Moved. (non-admin closure) Cwmhiraeth (talk) 11:41, 26 November 2019 (UTC)

---

Module:HS listed building → Module:HS listed building row – Match name with template * Pppery * _{it has begun...} 21:38, 8 November 2019 (UTC) —Relisting. ~~ CAPTAIN MEDUSA^talk 13:32, 16 November 2019 (UTC)

---

The above discussion is preserved as an archive of a requested move. Please do not modify it. Subsequent comments should be made in a new section on this talk page or in a move review. No further edits should be made to this section.

Bug when interlanguage wikilink is used at the end of name= parameter

An odd bug appears when an normal bracketed interlanguage wikilink is used at the end of the |name= parameter. See "Former Sun Life Building" at List of Category A listed buildings in Glasgow for an example. A stray )] appear after the coordinates, and Linter reports problems with mismatched span tags. – Jonesey95 (talk) 21:17, 12 March 2024 (UTC)