MediaWiki talk:Gadget-ProveIt.js

Use of "addOnloadHook" is deprecated. Use jQuery instead

Since addOnloadHook has been deprecated, could we change it to $? It's on line 667. Thanks! Chmarkine (talk) 22:54, 24 March 2014 (UTC)

It seems I should report this to GitHub. Close the request. Chmarkine (talk) 23:18, 25 March 2014 (UTC)

Protected edit request on 15 August 2016

The changes by User:Felipe Schenone made on 9th August and subsequently initially modified this JavaScript invoke the Commons version of the gadget. Now it simply invokes the Wikipedia version as it stood before the changes. This increases the server load for no benefit. This user has also blanked MediaWiki:Gadget-ProveIt.css, instead using this page to invoke the stylesheet as it was prior to blanking, and changed MediaWiki:Gadgets-definition, removing the list of dependencies although those dependencies clearly still exist. I suggest that this page, MediaWiki:Gadget-ProveIt.css and MediaWiki:Gadgets-definition should be reverted. Alternatively this page could invoke the Commons version of the gadget as per the edit on 9th August if that is preferred but the dependencies need to be restored on MediaWiki:Gadgets-definition.

Prh47bridge (talk) 08:43, 15 August 2016 (UTC)

@Prh47bridge: I have reverted the gadget definition and the pages MediaWiki:Gadget-ProveIt.js and MediaWiki:Gadget-ProveIt.css to the previous version. The changes I'm trying to do are part of a process to centralize the gadget code by serving it from Commons. The motivation behind these changes is to drive developers from all Wikipedias to contribute to the same code base, rather than having different versions of the gadgets on each Wikipedia. The Spanish Wikipedia currently runs a much more recent version of the gadget (though with a few bugs currently unacceptable here). The goal is that all Wikipedias soon run the same code. This will require, yes, requests to Commons that may increase the server load, but I think the benefits will be worth it. They aren't worth it of course, if we're serving the old version, so I reverted the definition and script pages. Thanks again for the report. If you want more info, check the discussion going on here. Cheers! --Felipe (talk) 18:17, 15 August 2016 (UTC)

Interface-protected edit request on 26 March 2019 (just updated from list of CS-1 style templates)

Change lines 31-45 from:

                       'Template:Citation',
                       'Template:Cite AV media',
                       'Template:Cite book',
                       'Template:Cite encyclopedia',
                       'Template:Cite episode',
                       'Template:Cite journal',
                       'Template:Cite magazine',
                       'Template:Cite news',
                       'Template:Cite paper',
                       'Template:Cite press release',
                       'Template:Cite sign',
                       'Template:Cite thesis',
                       'Template:Cite tweet',
                       'Template:Cite video',
                       'Template:Cite web'

to:

                       'Template:Citation',
                       'Template:Cite AV media',
                       'Template:Cite book',
                       'Template:Cite conference',
                       'Template:Cite encyclopedia',
                       'Template:Cite episode',
                       'Template:Cite interviewl',
                       'Template:Cite journal',
                       'Template:Cite magazine',
                       'Template:Cite map',
                       'Template:Cite newsgroup',
                       'Template:Cite news',
                       'Template:Cite paper',
                       'Template:Cite podcast',
                       'Template:Cite press release',
                       'Template:Cite report',
                       'Template:Cite sign',
                       'Template:Cite speech',
                       'Template:Cite techreport',
                       'Template:Cite thesis',
                       'Template:Cite tweet',
                       'Template:Cite video',
                       'Template:Cite web' Furicorn (talk) 04:10, 26 March 2019 (UTC)

 Not done for now: The comment in the code notes that all these templates need to have Template data defined. At least {{Cite map}} doesn't seem to have TemplateData. Please verify. —TheDJ (talk • contribs) 07:55, 26 March 2019 (UTC)

@TheDJ: Thanks, how can I distinguish templates with "Template data defined" versus those that don't? Also, if you wouldn't mind showing me what defined template data is, maybe I can get that information added to these templates so they can be used in ProveIt.

Furicorn The template data for e.g Template:Cite web is at Template:Cite web#TemplateData (see Wikipedia:TemplateData for more info). Galobtter (pingó mió) 16:57, 27 March 2019 (UTC)

Interface-protected edit request on 4 April 2019 - Cite Interview has TemplateData

I'd like to add {{Cite arXiv}}, {{Cite bioRxiv}}, {{Cite interview}}, and {{Cite report}} to ProveIt, as these templates now have TemplateData.

Change

'proveit-templates': [ // These templates should have their TemplateData defined
                        'Template:Citation',
                        'Template:Cite AV media',
                        'Template:Cite book',
                        'Template:Cite encyclopedia',
                        'Template:Cite episode',
                        'Template:Cite journal',
                        'Template:Cite magazine',
                        'Template:Cite news',
                        'Template:Cite paper',
                        'Template:Cite press release',
                        'Template:Cite sign',
                        'Template:Cite thesis',
                        'Template:Cite tweet',
                        'Template:Cite video',
                        'Template:Cite web'
                    ]

to

'proveit-templates': [ // These templates should have their TemplateData defined
                        'Template:Citation',
                        'Template:Cite arXiv',
                        'Template:Cite AV media',
                        'Template:Cite book',
                        'Template:Cite bioRxiv',
                        'Template:Cite encyclopedia',
                        'Template:Cite episode',
                        'Template:Cite interview',
                        'Template:Cite journal',
                        'Template:Cite magazine',
                        'Template:Cite news',
                        'Template:Cite paper',
                        'Template:Cite press release',
                        'Template:Cite report',
                        'Template:Cite sign',
                        'Template:Cite thesis',
                        'Template:Cite tweet',
                        'Template:Cite video',
                        'Template:Cite web'
                    ]

Furicorn (talk) 05:46, 4 April 2019 (UTC)

 Done —TheDJ (talk • contribs) 08:04, 4 April 2019 (UTC)